Genericized caching for localkube binary and minikube iso #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 32.88% (diff: 60.00%)@@ master #613 diff @@
==========================================
Files 44 45 +1
Lines 1929 1919 -10
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 633 631 -2
+ Misses 1168 1165 -3
+ Partials 128 123 -5
|
r2d4
force-pushed
the
localkube-sha
branch
2 times, most recently
from
ba34dcc
to
9685362
Compare
This also adds checksum checking for localkube versions. We will need to upload an additional localkube-linux-amd64.sha256 file as we do for the iso releases.
dlorenc
suggested changes
Sep 22, 2016
| URL: config.MinikubeISO, | ||
| ShaURL: constants.DefaultIsoShaUrl, | ||
| } | ||
| _, err := cache.GetFile(minikubeISO) |
There was a problem hiding this comment.
Do you need to at least close the file?
| ShaURL string | ||
| } | ||
|
|
||
| type DiskCache struct{} |
There was a problem hiding this comment.
I like this level of indirection, but it's a bit awkward for callers to have to make a var cache util.DiskCache before calling any methods.
What do you think about adding a static cache to the top level of this package, and adding a SetCache function to allow swapping it out?
Similar to this pattern from libmachine: https://github.com/docker/machine/blob/master/libmachine/ssh/client.go
|
Closing this for now as #624 has already fixed the main issue of checking localkube SHAs. Might be worth refactoring in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds checksum checking for localkube versions. We will need
to upload an additional localkube-linux-amd64.sha256 file as we do for
the iso releases.
ref #599 #602