Update golangci-lint to v1.18.0 #5351

tstromberg · 2019-09-13T21:08:07Z

Changelog

bb82273 Add funlen linter (#603)
91e90eb Add support for bash completions (#640)
a8f2c27 Add user supplied error messages in depguard issues (#662)
f84095a Build FreeBSD binaries (#613)
e87a1cf Fix a false-positive from 'unused' (#585)
338e3fb Fix install script on Windows (#626)
0b49095 Make generation of demo.svg deterministic (#625)
eabe43a Provide pre-built binary for ARM arch (#607)
375a5a8 Speed up linting: use deduplicated packages (#667)
6163a8a Support go1.13 (#670)
e1a7422 Update gochecknoglobals to support version exception (#601)
f8a5a8c Update depguard version to 1.0.0 (Performance improvements)
97fcafd Update format of junit xml output to mark failures as such (#632)
22d1ef6 Update pkg/errors to v0.8.1.
4ed1349 add kubeedge (#636)
d2b1eea bodyclose: fix race condition
f312a0f fix #416: Add skip-dirs-use-default (#630)
c5b0f95 fix cuncurrent [read/]write panic
cdeefb5 fix invalid dependencies (#605)
e175825 fix possible race in line cache
7e170af fix: body close panic.
136b271 update bodyclose: use upstream version (#666)
e39e8fb update x/tools

k8s-ci-robot · 2019-09-13T21:08:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TravisBuddy · 2019-09-13T21:13:26Z

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
make[1]: *** No rule to make target 'out/linters/golangci-lint', needed by 'lint-ci'.  Stop.
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.056s	coverage: 16.2% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.085s	coverage: 18.7% of statements
ok  	k8s.io/minikube/pkg/drivers	0.021s	coverage: 18.4% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.032s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.030s	coverage: 61.8% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	2.357s	coverage: 73.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.075s	coverage: 31.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.471s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.026s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.021s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.007s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.042s	coverage: 75.6% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.023s	coverage: 1.4% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.029s	coverage: 11.3% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.039s	coverage: 78.6% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.009s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.009s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.009s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.013s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.034s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/sshutil	0.302s	coverage: 75.0% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.004s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	2.097s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	1.464s	coverage: 62.0% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.004s	coverage: 59.1% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.002s	coverage: 0.0% of statements
ok
Makefile:232: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: 516885c0-d66b-11e9-82ee-13bec588d4b8

TravisBuddy · 2019-09-13T21:50:44Z

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.18.0'
golangci/golangci-lint info found version: 1.18.0 for v1.18.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
ok
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.091s	coverage: 16.2% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.050s	coverage: 18.7% of statements
ok  	k8s.io/minikube/pkg/drivers	0.014s	coverage: 18.4% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.056s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.027s	coverage: 61.8% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	2.917s	coverage: 73.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.055s	coverage: 31.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.659s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.024s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.012s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.008s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.075s	coverage: 75.6% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.023s	coverage: 1.4% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.032s	coverage: 11.3% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.023s	coverage: 78.6% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.009s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.047s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.017s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.017s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.038s	coverage: 35.9% of statements
--- FAIL: TestNewSSHClient (0.61s)
    ssh_mock.go:173: Listening on 127.0.0.1:37039
    ssh_mock.go:83: Accepting...
    ssh_mock.go:83: Accepting...
    ssh_mock.go:132: exec request received: &{Type:exec WantReply:true Payload:[0 0 0 3 102 111 111] ch:0xc00010c0c0 mux:<nil>}
    sshutil_test.go:60: Error running "foo": wait: remote command exited without exit status or exit signal
    ssh_mock.go:189: Stopping
FAIL
coverage: 75.0% of statements
FAIL	k8s.io/minikube/pkg/minikube/sshutil	0.619s
ok  	k8s.io/minikube/pkg/minikube/translate	0.004s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	2.061s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	0.944s	coverage: 62.0% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.008s	coverage: 59.1% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.016s	coverage: 0.0% of statements
Makefile:232: recipe for target 'test' failed
make: *** [test] Error 16

TravisBuddy Request Identifier: 8876f790-d670-11e9-82ee-13bec588d4b8

tstromberg · 2019-09-16T22:14:11Z

@minikube-bot OK to test

Update golangci-lint to v1.18.0

c1e4bcd

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2019

k8s-ci-robot requested review from josedonizetti and RA489 September 13, 2019 21:08

Update lint-ci rule

2d3138f

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2019

josedonizetti approved these changes Sep 16, 2019

View reviewed changes

tstromberg merged commit f5c0956 into kubernetes:master Sep 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update golangci-lint to v1.18.0 #5351

Update golangci-lint to v1.18.0 #5351

tstromberg commented Sep 13, 2019 •

edited

Loading

k8s-ci-robot commented Sep 13, 2019

TravisBuddy commented Sep 13, 2019

TravisBuddy commented Sep 13, 2019

tstromberg commented Sep 16, 2019

Update golangci-lint to v1.18.0 #5351

Update golangci-lint to v1.18.0 #5351

Conversation

tstromberg commented Sep 13, 2019 • edited Loading

Changelog

k8s-ci-robot commented Sep 13, 2019

TravisBuddy commented Sep 13, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 516885c0-d66b-11e9-82ee-13bec588d4b8

TravisBuddy commented Sep 13, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 8876f790-d670-11e9-82ee-13bec588d4b8

tstromberg commented Sep 16, 2019

tstromberg commented Sep 13, 2019 •

edited

Loading