Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove -master from package and install version #6002

Closed
wants to merge 1 commit into from

Conversation

afbjorklund
Copy link
Collaborator

Since we are back to using released versions now, we don't need to pull
unreleased commits directly from the master branch repository any longer.

It is still exactly the same versions of conmon and runc, just renamed.
Currently we don't require any patches to the latest releases of each.

For #5823

Since we are back to using released versions now, we don't need to pull
unreleased commits directly from the master branch repository any longer.

It is still exactly the same versions of conmon and runc, just renamed.
Currently we don't require any patches to the latest releases of each.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2019
@codecov-io
Copy link

Codecov Report

Merging #6002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6002   +/-   ##
=======================================
  Coverage   36.18%   36.18%           
=======================================
  Files         110      110           
  Lines        8214     8214           
=======================================
  Hits         2972     2972           
  Misses       4851     4851           
  Partials      391      391

@afbjorklund afbjorklund changed the title Remove -master from package and install version WIP: Remove -master from package and install version Dec 2, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2019
@afbjorklund
Copy link
Collaborator Author

Looks like Buildroot already has runc-1.0.0-rc8 in the default package list, so gets a naming conflict

https://github.com/buildroot/buildroot/tree/master/package/runc

@afbjorklund afbjorklund closed this Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants