Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide innocuous viper ConfigFileNotFoundError #5732

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

tstromberg
Copy link
Contributor

Fixes #4920
Based on the proposal by @RA489 in #4940 + review feedback

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tstromberg tstromberg changed the title Hide viper ConfigFileNotFoundError Hide innocuous viper ConfigFileNotFoundError Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
@codecov-io
Copy link

Codecov Report

Merging #5732 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5732   +/-   ##
=======================================
  Coverage   37.83%   37.83%           
=======================================
  Files         102      102           
  Lines        7601     7601           
=======================================
  Hits         2876     2876           
  Misses       4347     4347           
  Partials      378      378
Impacted Files Coverage Δ
cmd/minikube/cmd/root.go 54.1% <0%> (ø) ⬆️

@medyagh
Copy link
Member

medyagh commented Oct 25, 2019

KVM fails are related to : #5724 and #5723

Vbox Linux fails are related to #5724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the error message when Config file is not available
4 participants