-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the error message when Config file is not available #4920
Comments
Should be shown as a warning, not as an error ? err := viper.ReadInConfig()
if err != nil {
glog.Warningf("Error reading config file at %s: %v", configPath, err)
} The verbose log does have some "scary" messages. I supposed you could filter out But then it is hard to catch parameters that are wrong. |
My bad. Not an actual error but I mean that it should not state "Error" when clearly it is not an error but just that custom config is not present which needs to be applied. |
Apparently it will be a https://github.com/spf13/viper#reading-config-files And seems like glog doesn't show the severity level. |
/assign @RA489 |
Anyone know if this still happens in v1.4? I'm still confused as to why this output only appears in Windows. I would have expected to see it tucked away in the logs. |
Yep. Still happening on the latest build -
|
Made a PR, because this is confusing users and we probably shouldn't be parsing nonexistent files. |
The exact command to reproduce the issue:
minikube-windows-amd64.exe start --alsologtostderr --v=8
The full output of the command that failed:
The full output is correct but this first line kind of pops out -
The operating system version:
Windows 10 Enterprise.
Instead of showing it as an error, this needs a better solution message. Earlier, I used to see this and get confused as to what was wrong. Later on figured that this is rather the external custom config which is used.
The text was updated successfully, but these errors were encountered: