Add simple integration test for update-context #5652

tstromberg · 2019-10-17T21:33:39Z

To assert that #5626 does not regress

k8s-ci-robot · 2019-10-17T21:34:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TravisBuddy · 2019-10-17T21:43:24Z

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.20.0'
golangci/golangci-lint info found version: 1.20.0 for v1.20.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
test/integration/functional_test.go:333: File is not `goimports`-ed (goimports)

Makefile:335: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= go mod ================================================================
ok
Makefile:232: recipe for target 'test' failed
make: *** [test] Error 4
travis_time:end:2023be64:start=1571348164843056519,finish=1571348356097733908,duration=191254677389,event=script

TravisBuddy Request Identifier: 23be1870-f127-11e9-8a79-b94cfa9b3843

sharifelgamal · 2019-10-17T22:22:27Z

There's a lint error but otherwise LGTM.

TravisBuddy · 2019-10-21T18:30:38Z

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.12.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.12.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.20.0'
golangci/golangci-lint info found version: 1.20.0 for v1.20.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
test/integration/functional_test.go:428: File is not `goimports`-ed (goimports)

Makefile:341: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= go mod ================================================================
ok
Makefile:245: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: df293ca0-f430-11e9-9e15-dd9742ab6bc9

…update-context

codecov-io · 2019-10-21T19:01:44Z

Codecov Report

Merging #5652 into master will increase coverage by 0.33%.
The diff coverage is 18.75%.

@@            Coverage Diff             @@
##           master    #5652      +/-   ##
==========================================
+ Coverage   37.57%   37.91%   +0.33%     
==========================================
  Files         103      102       -1     
  Lines        7675     7589      -86     
==========================================
- Hits         2884     2877       -7     
+ Misses       4413     4334      -79     
  Partials      378      378

Impacted Files	Coverage Δ
cmd/minikube/cmd/update-context.go	`0% <0%> (ø)`	⬆️
cmd/minikube/cmd/stop.go	`0% <0%> (ø)`	⬆️
pkg/minikube/kubeconfig/kubeconfig.go	`55.38% <21.42%> (-0.27%)`	⬇️
cmd/minikube/cmd/config/validations.go	`34.84% <0%> (-0.98%)`	⬇️
pkg/minikube/cluster/cluster.go	`37.38% <0%> (-0.45%)`	⬇️
cmd/minikube/cmd/start.go	`21.06% <0%> (-0.04%)`	⬇️
cmd/minikube/cmd/delete.go	`28.49% <0%> (ø)`	⬆️
pkg/drivers/drivers.go
pkg/minikube/cluster/cluster_linux.go
pkg/drivers/common.go	`8.47% <0%> (ø)`
... and 1 more

RA489 · 2019-10-22T06:07:14Z

/ok-to-test

minikube-bot · 2019-11-05T02:38:37Z

Old binary: [170.928343618 177.772650584 179.27439357]
New binary: [180.167192383 161.740611682 169.81519511]
Average Old: 175.991796
Average New: 170.574333

medyagh · 2019-11-06T20:37:40Z

@tstromberg needs resolve conflict.

btw traiage party showed this PR as "Pull requests: Approved & Mergeable "

it would be cool if traige party could detect Needs Resolve Conflict

medyagh

needs resolve conflict

Add simple integration test for update-context

3b0f489

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2019

k8s-ci-robot requested review from afbjorklund and sharifelgamal October 17, 2019 21:34

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2019

sharifelgamal approved these changes Oct 17, 2019

View reviewed changes

tstromberg changed the title ~~Add simple integration test for update-context~~ WIP: Add simple integration test for update-context Oct 21, 2019

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2019

Merge branch 'master' into update-context

3c463df

tstromberg changed the title ~~WIP: Add simple integration test for update-context~~ Add simple integration test for update-context Oct 21, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2019

tstromberg added 3 commits October 21, 2019 11:40

Run goimports after merge

af6a8f4

Merge branch 'master' into update-context

3136477

Merge branch 'update-context' of github.com:tstromberg/minikube into …

3941db1

…update-context

Add more logging

e3b1461

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2019

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 22, 2019

kubernetes deleted a comment from minikube-bot Nov 5, 2019

medyagh requested changes Nov 6, 2019

View reviewed changes

tstromberg closed this Dec 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add simple integration test for update-context #5652

Add simple integration test for update-context #5652

tstromberg commented Oct 17, 2019 •

edited

Loading

k8s-ci-robot commented Oct 17, 2019

TravisBuddy commented Oct 17, 2019

sharifelgamal commented Oct 17, 2019

TravisBuddy commented Oct 21, 2019

codecov-io commented Oct 21, 2019 •

edited

Loading

RA489 commented Oct 22, 2019

minikube-bot commented Nov 5, 2019

medyagh commented Nov 6, 2019

medyagh left a comment

Add simple integration test for update-context #5652

Add simple integration test for update-context #5652

Conversation

tstromberg commented Oct 17, 2019 • edited Loading

k8s-ci-robot commented Oct 17, 2019

TravisBuddy commented Oct 17, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 23be1870-f127-11e9-8a79-b94cfa9b3843

sharifelgamal commented Oct 17, 2019

TravisBuddy commented Oct 21, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: df293ca0-f430-11e9-9e15-dd9742ab6bc9

codecov-io commented Oct 21, 2019 • edited Loading

Codecov Report

RA489 commented Oct 22, 2019

minikube-bot commented Nov 5, 2019

medyagh commented Nov 6, 2019

medyagh left a comment

Choose a reason for hiding this comment

tstromberg commented Oct 17, 2019 •

edited

Loading

codecov-io commented Oct 21, 2019 •

edited

Loading