-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix "minikube update-context" command fail #5626
Conversation
Hi @govargo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: govargo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #5626 +/- ##
=======================================
Coverage 36.89% 36.89%
=======================================
Files 102 102
Lines 7369 7369
=======================================
Hits 2719 2719
Misses 4297 4297
Partials 353 353
|
/assign @sharifelgamal |
@minikube-bot OK to test |
Thanks for fixing this! |
Thanks! I will follow up with a PR that adds update-context to our integration tests. |
@tstromberg |
What type of PR is this?
/kind bug
What this PR does / why we need it:
In minikube v1.4.0,
minikube update-context
command always fails.This PR fixes this bug of the command fail.
Which issue(s) this PR fixes:
Fixes #5497
Does this PR introduce a user-facing change?
Yes. this PR fixes bug in order to
minikube update-context
command work successfully.Before this PR,
minikube update-context
command always failsAfter this PR,
minikube update-context
command worksAdditional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: