Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "minikube update-context" command fail #5626

Merged
merged 1 commit into from
Oct 17, 2019
Merged

fix "minikube update-context" command fail #5626

merged 1 commit into from
Oct 17, 2019

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Oct 15, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

In minikube v1.4.0, minikube update-context command always fails.

This PR fixes this bug of the command fail.

Which issue(s) this PR fixes:

Fixes #5497

Does this PR introduce a user-facing change?

Yes. this PR fixes bug in order to minikube update-context command work successfully.

Before this PR, minikube update-context command always fails

1. minikube update-context(error)
update config: Kubeconfig does not have a record of the machine cluster

After this PR, minikube update-context command works

1. minikube update-context(success)
minikube IP was already correctly configured for xxx.xxx.xxx.xxx
(or)
minikube IP has been updated to point at xxx.xxx.xxx.xxx

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: govargo
To complete the pull request process, please assign sharifelgamal
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #5626 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5626   +/-   ##
=======================================
  Coverage   36.89%   36.89%           
=======================================
  Files         102      102           
  Lines        7369     7369           
=======================================
  Hits         2719     2719           
  Misses       4297     4297           
  Partials      353      353
Impacted Files Coverage Δ
cmd/minikube/cmd/update-context.go 0% <0%> (ø) ⬆️

@govargo
Copy link
Contributor Author

govargo commented Oct 15, 2019

/assign @sharifelgamal

@sharifelgamal
Copy link
Collaborator

@minikube-bot OK to test

@sharifelgamal
Copy link
Collaborator

Thanks for fixing this!

@tstromberg
Copy link
Contributor

Thanks! I will follow up with a PR that adds update-context to our integration tests.

@tstromberg tstromberg merged commit acec7e5 into kubernetes:master Oct 17, 2019
@govargo
Copy link
Contributor Author

govargo commented Oct 18, 2019

@tstromberg
Thank you for your Merge and integration tests PR.
I'll check that PR.
And I ’ll write integration tests from next PR if same situation.

@govargo govargo deleted the fix-update-context branch October 21, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.4.0] update-context: Kubeconfig does not have a record of the machine cluster
6 participants