Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download kvm2 driver #5085

Merged
merged 13 commits into from
Sep 11, 2019
4 changes: 0 additions & 4 deletions pkg/drivers/drivers.go
Original file line number Diff line number Diff line change
@@ -17,7 +17,6 @@ limitations under the License.
package drivers

import (
"fmt"
"io"
"io/ioutil"
"os"
@@ -169,8 +168,6 @@ func InstallOrUpdate(driver, destination string, minikubeVersion semver.Version)

v := ExtractVMDriverVersion(string(output))

fmt.Printf("InstallOrUpdate extracted version %s\n", v)

// if the driver doesn't return any version, download it
if len(v) == 0 {
return download(driver, destination)
@@ -181,7 +178,6 @@ func InstallOrUpdate(driver, destination string, minikubeVersion semver.Version)
return errors.Wrap(err, "can't parse driver version")
}

fmt.Printf("InstallOrUpdate version %s\n", minikubeVersion.String())
// if the current driver version is older, download newer
if vmDriverVersion.LT(minikubeVersion) {
return download(driver, destination)
8 changes: 0 additions & 8 deletions test/integration/driver_install_or_update_test.go
Original file line number Diff line number Diff line change
@@ -46,14 +46,6 @@ func TestDriverInstallOrUpdate(t *testing.T) {
{name: "driver-with-older-version", path: filepath.Join(*testdataDir, "kvm2-driver-without-version")},
}

ingressPath := filepath.Join(*testdataDir, "nginx-ing.yaml")
_, err := os.Stat(ingressPath)
if err != nil {
t.Fatalf("Expected ingress-ing to exist. test: %s, got: %v", "TestDriverInstallOrUpdate", err)
} else {
fmt.Printf("TestDriverInstallOrUpdate ingress exist at: %s\n", ingressPath)
}

for _, tc := range tests {
dir, err := ioutil.TempDir("", tc.name)
if err != nil {