Download kvm2 driver #5085

josedonizetti · 2019-08-15T00:30:23Z

fix for #4391

k8s-ci-robot · 2019-08-15T00:30:51Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josedonizetti
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cmd/minikube/cmd/root.go

josedonizetti · 2019-08-15T14:42:35Z

@afbjorklund @medyagh can I get some feedback on how this is designed? and any concerns?
I'm currently looking on writing some kind of integration test for it.

medyagh · 2019-08-21T23:14:38Z

the overall looks good to me ! my only nit is if it works on windows.

josedonizetti · 2019-08-21T23:27:44Z

@medyagh windows won't be supported. At least for now, it will only be for linux/kvm2 driver, and latter osx/hyperkit.

medyagh

@medyagh windows won't be supported. At least for now, it will only be for linux/kvm2 driver, and latter osx/hyperkit.

I guess we don't need drivers for windows so thats okay !

pkg/util/downloader.go

pkg/drivers/drivers.go

cmd/minikube/cmd/root.go

josedonizetti · 2019-08-22T00:24:46Z

@medyagh yup, the HyperV driver comes with the libmachine code, it's not an external binary.

tstromberg

Looks good for a first iteration. Can we merge this?

josedonizetti · 2019-08-26T14:59:57Z

@tstromberg This is working, so yeah we can merge, but I will keep working on it. Would it be okay to do it in following PRs?

tstromberg · 2019-09-05T18:49:25Z

Looks great: Let me know if I can provide any help to dig to the bottom of this integration test failure:

--- FAIL: TestDriverInstallOrUpdate (0.03s)
    driver_install_or_update_test.go:70: Expected driver to be download. test: driver-without-version-support, got: stat /tmp/driver-without-version-support758569209/docker-machine-driver-kvm2: no such file or directory

josedonizetti · 2019-09-10T03:24:12Z

@minikube-bot Ok to test

josedonizetti · 2019-09-10T23:00:04Z

@minikube-bot Ok to test

josedonizetti · 2019-09-11T00:57:44Z

/retest

josedonizetti · 2019-09-11T00:59:54Z

@minikube-bot Ok to test

TravisBuddy · 2019-09-11T01:14:43Z

Travis tests have failed

Hey @josedonizetti,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.17.1'
golangci/golangci-lint info found version: 1.17.1 for v1.17.1/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
ok
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.092s	coverage: 14.6% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.074s	coverage: 18.9% of statements
ok  	k8s.io/minikube/pkg/drivers	0.015s	coverage: 18.0% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.048s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.028s	coverage: 61.8% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	2.365s	coverage: 72.9% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.093s	coverage: 29.5% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.408s	coverage: 54.2% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.025s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.024s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.008s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.063s	coverage: 75.6% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.042s	coverage: 1.4% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.030s	coverage: 11.3% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.028s	coverage: 77.8% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.011s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.010s	coverage: 42.9% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.009s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.014s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.038s	coverage: 35.9% of statements
--- FAIL: TestNewSSHClient (0.63s)
    ssh_mock.go:173: Listening on 127.0.0.1:41465
    ssh_mock.go:83: Accepting...
    ssh_mock.go:83: Accepting...
    ssh_mock.go:132: exec request received: &{Type:exec WantReply:true Payload:[0 0 0 3 102 111 111] ch:0xc00010c0c0 mux:<nil>}
    sshutil_test.go:60: Error running "foo": wait: remote command exited without exit status or exit signal
    ssh_mock.go:189: Stopping
FAIL
coverage: 75.0% of statements
FAIL	k8s.io/minikube/pkg/minikube/sshutil	0.645s
ok  	k8s.io/minikube/pkg/minikube/translate	0.018s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	2.176s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	1.219s	coverage: 61.6% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.008s	coverage: 59.1% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.002s	coverage: 0.0% of statements
Makefile:232: recipe for target 'test' failed
make: *** [test] Error 16

TravisBuddy Request Identifier: 8829fd50-d431-11e9-847a-07722ef8bbdd

TravisBuddy · 2019-09-11T14:42:54Z

Travis tests have failed

Hey @josedonizetti,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.17.1'
golangci/golangci-lint info found version: 1.17.1 for v1.17.1/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
cmd/minikube/cmd/start_test.go:29:7: undeclared name: `extractVMDriverVersion` (typecheck)
	v := extractVMDriverVersion("")
	     ^
Makefile:334: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
# k8s.io/minikube/cmd/minikube/cmd [k8s.io/minikube/cmd/minikube/cmd.test]
cmd/minikube/cmd/start_test.go:29:7: undefined: extractVMDriverVersion
cmd/minikube/cmd/start_test.go:34:6: undefined: extractVMDriverVersion
cmd/minikube/cmd/start_test.go:41:6: undefined: extractVMDriverVersion
cmd/minikube/cmd/start_test.go:46:6: undefined: extractVMDriverVersion
FAIL	k8s.io/minikube/cmd/minikube/cmd [build failed]
ERROR: logging before flag.Parse: I0911 14:41:59.342698   10984 vm_assets.go:204] Created asset deploy/addons/addon-manager.yaml.tmpl with 1452 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.345019   10984 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-dp.yaml.tmpl with 1605 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.345099   10984 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-svc.yaml.tmpl with 979 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.345151   10984 vm_assets.go:204] Created asset deploy/addons/storageclass/storageclass.yaml.tmpl with 271 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.351558   10984 vm_assets.go:204] Created asset deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl with 1755 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.351633   10984 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-gluster-ns.yaml.tmpl with 230 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.351739   10984 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/glusterfs-daemonset.yaml.tmpl with 3935 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.351822   10984 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/heketi-deployment.yaml.tmpl with 4045 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.351893   10984 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-provisioner-glusterfile.yaml.tmpl with 3236 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.352253   10984 vm_assets.go:204] Created asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl with 2540 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.352316   10984 vm_assets.go:204] Created asset deploy/addons/heapster/grafana-svc.yaml.tmpl with 1085 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.352384   10984 vm_assets.go:204] Created asset deploy/addons/heapster/influxdb-svc.yaml.tmpl with 1048 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.352635   10984 vm_assets.go:204] Created asset deploy/addons/heapster/heapster-rc.yaml.tmpl with 1651 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.352730   10984 vm_assets.go:204] Created asset deploy/addons/heapster/heapster-svc.yaml.tmpl with 1006 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.352921   10984 vm_assets.go:204] Created asset deploy/addons/efk/elasticsearch-rc.yaml.tmpl with 2209 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.352987   10984 vm_assets.go:204] Created asset deploy/addons/efk/elasticsearch-svc.yaml.tmpl with 947 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.353788   10984 vm_assets.go:204] Created asset deploy/addons/efk/fluentd-es-rc.yaml.tmpl with 2096 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.353995   10984 vm_assets.go:204] Created asset deploy/addons/efk/fluentd-es-configmap.yaml.tmpl with 9863 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.354089   10984 vm_assets.go:204] Created asset deploy/addons/efk/kibana-rc.yaml.tmpl with 1606 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.354153   10984 vm_assets.go:204] Created asset deploy/addons/efk/kibana-svc.yaml.tmpl with 1011 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.354257   10984 vm_assets.go:204] Created asset deploy/addons/ingress/ingress-configmap.yaml.tmpl with 1281 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.354325   10984 vm_assets.go:204] Created asset deploy/addons/ingress/ingress-rbac.yaml.tmpl with 2575 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.354592   10984 vm_assets.go:204] Created asset deploy/addons/ingress/ingress-dp.yaml.tmpl with 3045 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.354765   10984 vm_assets.go:204] Created asset deploy/addons/metrics-server/metrics-apiservice.yaml.tmpl with 401 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.354961   10984 vm_assets.go:204] Created asset deploy/addons/metrics-server/metrics-server-deployment.yaml.tmpl with 660 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.355025   10984 vm_assets.go:204] Created asset deploy/addons/metrics-server/metrics-server-service.yaml.tmpl with 401 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.355099   10984 vm_assets.go:204] Created asset deploy/addons/registry/registry-rc.yaml.tmpl with 748 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.355168   10984 vm_assets.go:204] Created asset deploy/addons/registry/registry-svc.yaml.tmpl with 333 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.355242   10984 vm_assets.go:204] Created asset deploy/addons/registry/registry-proxy.yaml.tmpl with 878 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.355331   10984 vm_assets.go:204] Created asset deploy/addons/registry-creds/registry-creds-rc.yaml.tmpl with 2868 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.355543   10984 vm_assets.go:204] Created asset deploy/addons/freshpod/freshpod-rc.yaml.tmpl with 1437 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.355840   10984 vm_assets.go:204] Created asset deploy/addons/gpu/nvidia-driver-installer.yaml.tmpl with 2487 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.356104   10984 vm_assets.go:204] Created asset deploy/addons/gpu/nvidia-gpu-device-plugin.yaml.tmpl with 2111 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.356219   10984 vm_assets.go:204] Created asset deploy/addons/logviewer/logviewer-dp-and-svc.yaml.tmpl with 1942 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.356303   10984 vm_assets.go:204] Created asset deploy/addons/logviewer/logviewer-rbac.yaml.tmpl with 1064 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.356527   10984 vm_assets.go:204] Created asset deploy/addons/gvisor/gvisor-pod.yaml.tmpl with 1941 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.356601   10984 vm_assets.go:204] Created asset deploy/addons/gvisor/gvisor-runtimeclass.yaml with 798 bytes
ERROR: logging before flag.Parse: I0911 14:41:59.356795   10984 vm_assets.go:204] Created asset deploy/addons/gvisor/gvisor-config.toml with 1738 bytes
--- FAIL: TestUnsetConfig (0.00s)
    unset_test.go:30: Failed to set the property "cpus"
    unset_test.go:35: Failed to read config "specified key could not be found in config"
    unset_test.go:39: Expected cpus to be 1 but got 
    unset_test.go:44: Failed to unset property "create /home/travis/.minikube/config/config.json: open /home/travis/.minikube/config/config.json: no such file or directory"
FAIL
coverage: 18.9% of statements
FAIL	k8s.io/minikube/cmd/minikube/cmd/config	0.065s
ok  	k8s.io/minikube/pkg/drivers	0.021s	coverage: 18.4% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.047s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.040s	coverage: 61.8% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	3.259s	coverage: 72.9% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.115s	coverage: 29.5% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.390s	coverage: 54.2% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.025s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.011s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.010s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.055s	coverage: 75.6% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.029s	coverage: 1.4% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.053s	coverage: 11.3% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.029s	coverage: 81.5% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.009s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.010s	coverage: 42.9% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.018s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.052s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.043s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/sshutil	0.155s	coverage: 75.0% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.004s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	2.033s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	2.135s	coverage: 61.6% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.005s	coverage: 59.1% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.002s	coverage: 0.0% of statements
Makefile:232: recipe for target 'test' failed
make: *** [test] Error 20

TravisBuddy Request Identifier: 6e1dada0-d4a2-11e9-847a-07722ef8bbdd

tstromberg · 2019-09-11T17:03:54Z

w00t!

This is a huge usability improvement for Linux users. Thank you so much!

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2019

k8s-ci-robot requested review from afbjorklund and RA489 August 15, 2019 00:30

afbjorklund reviewed Aug 15, 2019

View reviewed changes

cmd/minikube/cmd/root.go Outdated Show resolved Hide resolved

josedonizetti force-pushed the download-kvm2-driver branch 2 times, most recently from 279a3b0 to 90a12d5 Compare August 15, 2019 14:39

medyagh reviewed Aug 21, 2019

View reviewed changes

pkg/util/downloader.go Show resolved Hide resolved

pkg/drivers/drivers.go Outdated Show resolved Hide resolved

pkg/drivers/drivers.go Show resolved Hide resolved

cmd/minikube/cmd/root.go Show resolved Hide resolved

tstromberg approved these changes Aug 26, 2019

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2019

josedonizetti changed the title ~~wip: Download kvm2 driver~~ Download kvm2 driver Sep 4, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2019

josedonizetti force-pushed the download-kvm2-driver branch from adbee98 to 87f2109 Compare September 4, 2019 11:47

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2019

medyagh approved these changes Sep 5, 2019

View reviewed changes

josedonizetti force-pushed the download-kvm2-driver branch 2 times, most recently from 744c923 to dfdd46a Compare September 10, 2019 15:41

josedonizetti force-pushed the download-kvm2-driver branch from 60722c2 to 0331e4f Compare September 11, 2019 00:41

josedonizetti force-pushed the download-kvm2-driver branch from 9564844 to 9c4a97e Compare September 11, 2019 01:42

josedonizetti added 12 commits September 11, 2019 11:34

Download kvm2 driver

30e75c3

Add drivers.InstallOrUpdate acceptance tests

0cf4921

Skipe driver intallOrUpdate test for none driver

ce93bd0

Fix testdata directory for driver install or update test

44889de

Add debugging information

e30fe10

Remove deggubing information

85778d3

Add recursive copy to test/integration/testdata

f22a8ce

Add log lines to debug test

219109c

Add full driver folder path

3bb79f6

Change driver permission

5232043

Remove debug logs

c434797

Restore original PATH

6898cb1

josedonizetti force-pushed the download-kvm2-driver branch from 32a4c6e to 6898cb1 Compare September 11, 2019 14:35

Remove old test

e5cc21c

tstromberg merged commit da3890c into kubernetes:master Sep 11, 2019

josedonizetti deleted the download-kvm2-driver branch September 11, 2019 17:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Download kvm2 driver #5085

Download kvm2 driver #5085

josedonizetti commented Aug 15, 2019

k8s-ci-robot commented Aug 15, 2019

josedonizetti commented Aug 15, 2019 •

edited

Loading

medyagh commented Aug 21, 2019

josedonizetti commented Aug 21, 2019 •

edited

Loading

medyagh left a comment

josedonizetti commented Aug 22, 2019

tstromberg left a comment

josedonizetti commented Aug 26, 2019

tstromberg commented Sep 5, 2019

josedonizetti commented Sep 10, 2019

josedonizetti commented Sep 10, 2019

josedonizetti commented Sep 11, 2019

josedonizetti commented Sep 11, 2019

TravisBuddy commented Sep 11, 2019

TravisBuddy commented Sep 11, 2019

tstromberg commented Sep 11, 2019 •

edited

Loading

Download kvm2 driver #5085

Download kvm2 driver #5085

Conversation

josedonizetti commented Aug 15, 2019

k8s-ci-robot commented Aug 15, 2019

josedonizetti commented Aug 15, 2019 • edited Loading

medyagh commented Aug 21, 2019

josedonizetti commented Aug 21, 2019 • edited Loading

medyagh left a comment

Choose a reason for hiding this comment

josedonizetti commented Aug 22, 2019

tstromberg left a comment

Choose a reason for hiding this comment

josedonizetti commented Aug 26, 2019

tstromberg commented Sep 5, 2019

josedonizetti commented Sep 10, 2019

josedonizetti commented Sep 10, 2019

josedonizetti commented Sep 11, 2019

josedonizetti commented Sep 11, 2019

TravisBuddy commented Sep 11, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 8829fd50-d431-11e9-847a-07722ef8bbdd

TravisBuddy commented Sep 11, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 6e1dada0-d4a2-11e9-847a-07722ef8bbdd

tstromberg commented Sep 11, 2019 • edited Loading

josedonizetti commented Aug 15, 2019 •

edited

Loading

josedonizetti commented Aug 21, 2019 •

edited

Loading

tstromberg commented Sep 11, 2019 •

edited

Loading