Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-machine-driver-kvm2 version #4612

Merged
merged 2 commits into from
Jun 28, 2019

Conversation

josedonizetti
Copy link
Member

Change kvm2 version flag, to match minikube as suggested: #4593 (comment)

WIP: still waiting on the decision of which version to use for the drivers minikube version or commitID.
discussion at: #4593 (comment)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @josedonizetti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from balopat and medyagh June 26, 2019 21:24
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josedonizetti
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented Jun 26, 2019

Change kvm2 version flag, to match minikube as suggested: #4593 (comment)

WIP: still waiting on the decision of which version to use for the drivers minikube version or commitID.
discussion at: #4593 (comment)

we could have both version and commit id in two separate lines. (like current minikube head)

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 28, 2019
@josedonizetti josedonizetti changed the title WIP: Fix docker-machine-driver-kvm2 version Fix docker-machine-driver-kvm2 version Jun 28, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2019
@josedonizetti
Copy link
Member Author

docker-machine-driver-kvm2 version
version: v1.2.0
gitCommitID: 86cd3c67976adfb6502715f6002ed794880fdf54-dirty

@medyagh wdyt?

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

cmd/drivers/kvm/main.go Outdated Show resolved Hide resolved
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@josedonizetti
Copy link
Member Author

josedonizetti commented Jun 28, 2019

@medyagh done

I'll change the hyperkit side now.

@medyagh medyagh merged commit 8acf482 into kubernetes:master Jun 28, 2019
@josedonizetti josedonizetti deleted the fix-kvm-version branch June 28, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants