Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperkit version #4593

Merged
merged 3 commits into from
Jul 1, 2019
Merged

Conversation

josedonizetti
Copy link
Member

@josedonizetti josedonizetti commented Jun 25, 2019

FIx #4387 for hyperkit

About integration tests, I'm checking first where to add it, I'll do for the kvm2 first driver than if okay, in a separate PR for the hyperkit too.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @josedonizetti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 25, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josedonizetti
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Jun 25, 2019

@minikube-bot OK to test

pkg/drivers/hyperkit/version.go Show resolved Hide resolved
"github.com/docker/machine/libmachine/drivers/plugin"
"k8s.io/minikube/pkg/drivers/hyperkit"
)

func main() {
if len(os.Args) > 1 && os.Args[1] == "--version" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change this to "version" instead of "--version" in both here and kvm2 driver, to be consistent with minikube. it took me a couple miniutes to figure out this one is different than minikube

@medyagh
Copy link
Member

medyagh commented Jun 29, 2019

@josedonizetti I think needs a rebase

@josedonizetti
Copy link
Member Author

docker-machine-driver-hyperkit version

version: v1.2.0
commit: a9523fb793da81108bfb0a103fa6d424badae49d-dirty

@RA489
Copy link

RA489 commented Jul 1, 2019

@minikube-bot OK to test

@medyagh medyagh merged commit 2aac268 into kubernetes:master Jul 1, 2019
@josedonizetti josedonizetti deleted the add-hyperkit-version branch July 1, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --version to kvm2 driver
5 participants