Escape systemd special chars in docker-env #3997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
Can one of the admins verify this patch? |
11janci
force-pushed
the
jjanik-docker-env-escape
branch
from
94ce57e
to
106466c
Compare
11janci
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
11janci
force-pushed
the
jjanik-docker-env-escape
branch
from
106466c
to
6f9481c
Compare
k8s-ci-robot
added
size/L
11janci
force-pushed
the
jjanik-docker-env-escape
branch
4 times, most recently
from
bce4bf3
to
e5a6587
Compare
11janci
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @afbjorklund |
k8s-ci-robot
added
size/M
11janci
force-pushed
the
jjanik-docker-env-escape
branch
from
8d7ad3d
to
f451a45
Compare
11janci
force-pushed
the
jjanik-docker-env-escape
branch
from
f451a45
to
e3cd272
Compare
|
/lgtm /approve Looks good, thanks for the analysis and test cases! |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 11janci, afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --docker-env param is interpolated into systemd unit file for docker engine. Any special characters that systemd provides for use in templates will be interpreted by systemd. Since minikube does not support these special characters in docker-env, we must escape them so that systemd does not interpret them as special chars.
See examples in the below issue.
Note: this PR deals only with the docker-env param which gets inserted into the Environment option of the systemd unit file. Other parts of the file are omitted.
Closes #3812