-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy settings by --docker-env http_proxy fails with percent encoded chars #3812
Comments
At last with the windows version: If you are behind a proxy and your auth name is for example an email, like "[email protected]", you will have an proxy settings like this: http_proxy=http://user%40example.com:[email protected]:8080 The "%40" is the needed and a legal url encoded part- If you call now minikube start --docker-env HTTP_PROXY=http://user%40example.com:[email protected]:8080 the HTTP_PROXY will not be set in the created VM. Which is easily to test on another terminal with In fact every percent encode sign will fail. To see the effect, change the request to a double @ and the HTTP_PROXY env will be set. |
As a note: The env var will be silent skipped, there is no error message or warning. |
Thank you for your bug report! This sounds like a terrible experience, and I would be happy to review any PR's which address this. Help wanted! |
OP on company account. This bug seems to have it root in the --docker-env parser part and when i should guess its related to a broken string processing/pipe by not respecting the double quotes. A single space in the NO_PROXY rules will break the VM too. a.) minikube start --docker-env "NO_PROXY=1.2.3.4,5.6.7.8" Output of minikube in the terminal: Output with minikube ssh & systemctl show --property=Environment docker a.) Environment=DOCKER_RAMDISK=yes NO_PROXY=1.2.3.4,5.6.7.8 A buggy string processing of the arguments would also explain the behaviour with the procent encoded string part of the proxy settings - minukube and/or the bash should read the % part then as variable, if i understand this right. |
I will take a look at this |
We start to get the idea this is perhaps not a problem of minikube but of the docker daemon, which can't set the env vars from minikube when they are not in the perfect format. |
@MichtToen found the cause of the issue - you were close, except it is not a problem of docker but systemd (the input env vars must be escaped). I will come up with a PR that will do it next week. |
Great! Thank you! |
If this is a bug report, please include:
The text was updated successfully, but these errors were encountered: