-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added localkube and dependencies #39
Conversation
Looks great! One small request though, could you update the README.md to show the change to ./out/minikube instead of ./minikube in the instructions? I'll have to think a bit about the folder structure, but this is probably fine for now. I was hoping to have the top level "cli" folder be the code for the minikube CLI, and have other top-level folders handle other things (I'm working on one for iso/ which will contain the code to build our VM .iso file). But this layout has some advantages too. I'll think about it a little more, but we can clean that up later. |
Great! A note/proposal on folder structure: At least, we should keep command line parsing etc. in |
SGTM, I like that layout as well. Getting this in unblocks some other work, so I think we should proceed and change the layout in a followup. |
Yay! Thanks @mfburnett and @ethernetdan! |
Woot! Thanks @ethernetdan ! |
…true --router=true Incorporate changes suggested by @jimmidyson
Fixes kubernetes#39: You can use minishift start
Closes #7 by having Redspread contribute localkube to a Kubernetes maintained repository. The plan is currently to deprecate localkube as it's own project and focus our development efforts on minikube.
We continued using Godeps to vendor the dependencies though I am very interested in switching to Glide. In the short time I've spent maintaining localkube have found managing Kubernetes as a dependency can be challenging with Godeps.
While I added compiling the localkube binary to the build script, the minikube cli still uses the Redspread bundled version of localkube (#15).
A ported version of kube2sky is being used here as the original package does not allow external access. I am highly in favor moving to a centrally maintained when that becomes available, there is a PR in to open up access (kubernetes/kubernetes#25061).