-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle the localkube binary with the release #15
Comments
Do we plan on supporting in-place upgrades? If yes, injecting localkube will be useful.. |
Good point. Injecting at boot time would help there. One approach we can use to bundle the binary might be to use something like go-bindata: https://github.com/jteeuwen/go-bindata This would let us ship just a single binary with everything in it, including the components that run in the guest image. |
`go-bindata` sounds promosing. Another alternative is to do something
similar to `hyperkube`. We can have `minikube` run `localkube` if it is
invoked as `localkube`.
|
Yeah, that could work too. But we'd still need to get the binary itself into the VM. I guess we could have minikube send itself into the VM over scp, and then rename that file to localkube. |
Whoops, that wouldn't work on OSX/windows since we need localkube to be amd64 inside the vm and minikube to be darwin on the outside :) We'll have to bundle a separate binary. |
This is fixed with #66 |
Fix up minishift dashboard port
Rather than fetching it from github, we should include a fixed copy of the localkube binary that will run in the VM. This can either be transferred in from the minikube CLI or baked into the VM image.
The text was updated successfully, but these errors were encountered: