Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle the localkube binary with the release #15

Closed
dlorenc opened this issue Apr 25, 2016 · 6 comments
Closed

Bundle the localkube binary with the release #15

dlorenc opened this issue Apr 25, 2016 · 6 comments
Milestone

Comments

@dlorenc
Copy link
Contributor

dlorenc commented Apr 25, 2016

Rather than fetching it from github, we should include a fixed copy of the localkube binary that will run in the VM. This can either be transferred in from the minikube CLI or baked into the VM image.

@dlorenc dlorenc added this to the 0.1 Release milestone Apr 25, 2016
@vishh
Copy link
Contributor

vishh commented Apr 26, 2016

Do we plan on supporting in-place upgrades? If yes, injecting localkube will be useful..

@dlorenc
Copy link
Contributor Author

dlorenc commented Apr 26, 2016

Good point. Injecting at boot time would help there. One approach we can use to bundle the binary might be to use something like go-bindata: https://github.com/jteeuwen/go-bindata

This would let us ship just a single binary with everything in it, including the components that run in the guest image.

@vishh
Copy link
Contributor

vishh commented Apr 26, 2016 via email

@dlorenc
Copy link
Contributor Author

dlorenc commented Apr 26, 2016

Yeah, that could work too. But we'd still need to get the binary itself into the VM. I guess we could have minikube send itself into the VM over scp, and then rename that file to localkube.

@dlorenc
Copy link
Contributor Author

dlorenc commented Apr 27, 2016

Whoops, that wouldn't work on OSX/windows since we need localkube to be amd64 inside the vm and minikube to be darwin on the outside :) We'll have to bundle a separate binary.

@dlorenc
Copy link
Contributor Author

dlorenc commented May 14, 2016

This is fixed with #66

@dlorenc dlorenc closed this as completed May 14, 2016
jimmidyson added a commit to jimmidyson/minikube that referenced this issue Sep 2, 2016
s-urbaniak pushed a commit to s-urbaniak/minikube that referenced this issue Oct 13, 2016
s-urbaniak pushed a commit to s-urbaniak/minikube that referenced this issue Oct 13, 2016
klaases pushed a commit to klaases/minikube that referenced this issue Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants