Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve building of deb package (versioning and permissions) #3745

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Improve building of deb package (versioning and permissions) #3745

merged 2 commits into from
Feb 26, 2019

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Feb 24, 2019 •
edited
Loading

#3741 "The deb package has wrong revision"
#3544 "Bad file ownership in minikube deb packages"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2019
@afbjorklund
Copy link
Collaborator Author

@balopat : maybe we should change the package maintainer, as well ?

 Package: minikube
 Version: 0.34.1
 Section: base
 Priority: optional
 Architecture: amd64
 Recommends: virtualbox
 Maintainer: Aaron Prindle <[email protected]>

https://github.com/kubernetes/minikube/blob/master/installers/linux/deb/minikube_deb_template/DEBIAN/control#L7

@afbjorklund afbjorklund merged commit dc39b13 into kubernetes:master Feb 26, 2019
@leifcr leifcr mentioned this pull request Mar 8, 2019
Closed
@afbjorklund afbjorklund deleted the deb branch March 13, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc Awaiting requested review from dlorenc

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afbjorklund @k8s-ci-robot