Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The deb package has the wrong revision #3741

Closed
afbjorklund opened this issue Feb 24, 2019 · 0 comments
Closed

The deb package has the wrong revision #3741

afbjorklund opened this issue Feb 24, 2019 · 0 comments
Labels
os/linux packaging/apt Debian (apt) packaging issues

Comments

@afbjorklund
Copy link
Collaborator

Currently we always build major.minor version and then put the third digit into the revision:

DEB_VERSION ?= $(VERSION_MAJOR).$(VERSION_MINOR)-$(VERSION_BUILD)

https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-version

The version number of a package. The format is: [epoch:]upstream_version[-debian_revision].


This means that we have now built 0.34 twice, once for v0.34.0 and once for v0.34.1:

https://github.com/kubernetes/minikube/releases/download/v0.34.0/minikube_0.34-0.deb

https://github.com/kubernetes/minikube/releases/download/v0.34.1/minikube_0.34-1.deb

We should change this to match our tags/releases (0.34.0, 0.34.1), and drop revision (or 0):

The absence of a debian_revision is equivalent to a debian_revision of 0.

Since we don't build anything but just re-package, we don't need a revision.

@afbjorklund afbjorklund changed the title The deb version has the wrong release The deb version has the wrong revision Feb 24, 2019
@afbjorklund afbjorklund added packaging/apt Debian (apt) packaging issues os/linux labels Feb 24, 2019
@afbjorklund afbjorklund changed the title The deb version has the wrong revision The deb package has the wrong revision Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os/linux packaging/apt Debian (apt) packaging issues
Projects
None yet
Development

No branches or pull requests

1 participant