Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When copying assets from .minikube/files on windows, directories get squashed during transfer. ie /etc/ssl/certs/test.pem becomes ~minikube/etcsslcerts/test.pem. This pull request ensures any window style directories are converted into unix style. #3258

Merged
merged 2 commits into from
Feb 8, 2019
Merged

When copying assets from .minikube/files on windows, directories get squashed during transfer. ie /etc/ssl/certs/test.pem becomes ~minikube/etcsslcerts/test.pem. This pull request ensures any window style directories are converted into unix style. #3258

merged 2 commits into from
Feb 8, 2019

Commits on Oct 16, 2018

  1. this attempts to resolve 

    kubernetes#2768
for Windows, by converting \ in directory string to / and using
`path.Join` instead of `filepath.Join` which uses Unix format
instead of using he current OS directory delimeter.
    Nicholas Irving committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    c05b969 View commit details
    Browse the repository at this point in the history

  2. Resolved ordering issue

    Nicholas Irving committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    aca02f4 View commit details
    Browse the repository at this point in the history