When copying assets from .minikube/files on windows, directories get squashed during transfer. ie /etc/ssl/certs/test.pem becomes ~minikube/etcsslcerts/test.pem. This pull request ensures any window style directories are converted into unix style.

[darkedges]

review #2768 by converting \ in directory string to / and using path.Join instead of filepath.Join which uses Unix format instead of using he current OS directory delimeter.

May not be BP but it works for me.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[minikube-bot]

Can one of the admins verify this patch?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: darkedges
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: balopat

If they are not already assigned, you can assign the PR to them by writing /assign @balopat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[darkedges]

I have now signed the agreement.

[tstromberg]

Can you name the PR in such a way that specifically describes what this PR is doing? I'm not sure what
squashed means in this context.

I'm not yet familiar with Go on Windows, but the PR looks strange: filepath.Join works on Windows, but I'm really not sure why minikube was joining it with "/" in the first place. It seems like vmpath should instead be:

vmpath  := filepath.Abs(rPath) 

Does that achieve the expected result for you?

[darkedges]

Does that achieve the expected result for you?

The problem is that filepath is OS specific, so a directory in windows etc\ssl\certs becomes etcsslcerts instead of etc/ssl/certs when transferred to the minkube host. All this PR does is ensure any windows style directory string is converted into unix style before being transported to the minikube host. Without this files are not transferred to the correct location on the minikube host.

behavior without PR

behavior with PR

[balopat]

@minikube-bot OK to test

[sharamall]

any update from maintainers or PR owner?

[darkedges]

Just waiting for approval.

[darkedges]

/assign @balopat

[tstromberg]

@minikube-bot OK to test