Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include ISO URL and reduce stutter in download error message #3221

Merged
merged 2 commits into from
Oct 19, 2018
Merged

Include ISO URL and reduce stutter in download error message #3221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e54a16
Include ISO URL in download error, make output slightly easier to read.
tstromberg Oct 5, 2018
3e256a0
Fix accidental switch from Println to Printf
tstromberg Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/minikube/cluster/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ func createHost(api libmachine.API, config cfg.MachineConfig) (*host.Host, error

if config.VMDriver != "none" {
if err := config.Downloader.CacheMinikubeISOFromURL(config.MinikubeISO); err != nil {
return nil, errors.Wrap(err, "Error attempting to cache minikube ISO from URL")
return nil, errors.Wrap(err, "unable to cache ISO")
}
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/util/downloader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (f DefaultDownloader) CacheMinikubeISOFromURL(isoURL string) error {

fmt.Println("Downloading Minikube ISO")
if err := download.ToFile(isoURL, f.GetISOCacheFilepath(isoURL), options); err != nil {
return errors.Wrap(err, "Error downloading Minikube ISO")
return errors.Wrap(err, isoURL)
}

return nil
Expand Down