Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include ISO URL and reduce stutter in download error message #3221

Merged
merged 2 commits into from
Oct 19, 2018
Merged

Include ISO URL and reduce stutter in download error message #3221

merged 2 commits into from
Oct 19, 2018

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Oct 5, 2018 •
edited
Loading

Before:

Error starting host:
Error attempting to cache minikube ISO from URL:
Error downloading Minikube ISO: failed to download:
failed to download to temp file:
download failed: 1 error(s) occurred:

After:

Error starting host:
unable to cache ISO:
https://storage.googleapis.com/minikube/iso/minikube-v0.29-y.0.iso:
failed to download:
failed to download to temp file:
download failed: 1 error(s) occurred:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 5, 2018
balopat
balopat approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tstromberg tstromberg merged commit b93c22b into kubernetes:master Oct 19, 2018
@tstromberg tstromberg deleted the iso_errors branch October 19, 2018 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@aaron-prindle aaron-prindle Awaiting requested review from aaron-prindle

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tstromberg @k8s-ci-robot @balopat