Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the way 'minikube status' finds the kubecfg file. #1736

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Jul 24, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 24, 2017
@dlorenc
Copy link
Contributor Author

dlorenc commented Jul 24, 2017

I think this is why #1694 is currently failing.

@codecov-io
Copy link

Codecov Report

Merging #1736 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1736      +/-   ##
==========================================
- Coverage   36.26%   36.22%   -0.05%     
==========================================
  Files          51       51              
  Lines        3367     3368       +1     
==========================================
- Hits         1221     1220       -1     
- Misses       1965     1967       +2     
  Partials      181      181
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 14.21% <0%> (+0.32%) ⬆️
cmd/minikube/cmd/status.go 9.25% <0%> (ø) ⬆️
cmd/util/util.go 39.39% <0%> (-1.49%) ⬇️
pkg/util/kubeconfig/config.go 45.45% <0%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a7d71...6ea56d1. Read the comment docs.

@dlorenc dlorenc merged commit 24e08b7 into kubernetes:master Jul 24, 2017
@dlorenc dlorenc deleted the kubecfg branch July 24, 2017 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants