Stop using insecure serving. #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
dlorenc
commented
Jul 13, 2017
pkg/localkube/apiserver.go
Outdated
| // hostport := net.JoinHostPort(lk.APIServerInsecureAddress.String(), strconv.Itoa(lk.APIServerInsecurePort)) | ||
| // addr := "http://" + path.Join(hostport, "healthz") | ||
| return noop | ||
| // return healthCheck(addr) |
There was a problem hiding this comment.
This needs to get turned back on over the new address.
Codecov Report
@@ Coverage Diff @@
## master #1694 +/- ##
==========================================
+ Coverage 36.76% 37.29% +0.52%
==========================================
Files 51 51
Lines 3321 3365 +44
==========================================
+ Hits 1221 1255 +34
- Misses 1920 1928 +8
- Partials 180 182 +2
Continue to review full report at Codecov.
|
r2d4
reviewed
Jul 13, 2017
pkg/localkube/kubelet.go
Outdated
| @@ -29,7 +30,8 @@ func StartKubeletServer(lk LocalkubeServer) func() error { | |||
| config := options.NewKubeletServer() | |||
|
|
|||
| // Master details | |||
| config.APIServerList = []string{lk.GetAPIServerInsecureURL()} | |||
| config.KubeConfig = flag.NewStringFlag("/var/lib/localkube/kubeconfig") | |||
There was a problem hiding this comment.
Should this be pointing at util.DefaultKubeConfigPath?
|
Fixes #1628 |
dlorenc
force-pushed
the
noinsecure
branch
9 times, most recently
from
30c76bd
to
a3563b3
Compare
dlorenc
force-pushed
the
noinsecure
branch
11 times, most recently
from
5016ce2
to
511cb9c
Compare
|
This is ready for a final look. |
aaron-prindle
approved these changes
Jul 26, 2017
| config.InsecureServing.BindAddress = lk.APIServerInsecureAddress | ||
| config.InsecureServing.BindPort = lk.APIServerInsecurePort | ||
| // 0 turns off insecure serving. | ||
| config.InsecureServing.BindPort = 0 |
There was a problem hiding this comment.
We could also change the default to be 0 as this option might want to be configured by users. I am not sure if this is something users might rely on, the insecure api-server but I am seeing issues with the --none driver currently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly done. I want to add an integration test to verify nothing is serving on 8080.
I had to modify addon-manager.yaml to pass in the kubeconfig, I'm not sure how other environments do this. I wasn't able to find any examples.