Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node E2E: Shorten consistently check timeout of runtime conformance test #25695

Merged

Conversation

Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented May 16, 2016

#24191 increased the node e2e running time by almost half an hour. It makes the test running time exceed 60 minutes timeout, which causes quite a few issues (See #25639).

As a quite fix, we'll skip all the runtime conformance test. @liangchenye We should remove redundant test cases in #24191 such as #24191 (comment), and reduce the test running time as much as possible.

@Random-Liu Random-Liu added area/test priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 16, 2016
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels May 16, 2016
@pwittrock pwittrock added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2016
@Random-Liu Random-Liu force-pushed the skip-runtime-conformance-test branch from 8eb4826 to d1ab3b7 Compare May 16, 2016 23:38
@Random-Liu Random-Liu added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 16, 2016
@Random-Liu Random-Liu changed the title Node E2E: Skip runtime conformance test Node E2E: Shorten consistently check timeout of runtime conformance test May 16, 2016
@Random-Liu
Copy link
Member Author

Random-Liu commented May 16, 2016

@pwittrock @liangchenye Updated the PR to shorten the consistently check timeout. It turns out that the 4 * 5 * time.Minute consistently check is the root cause of long test running.

@pwittrock pwittrock added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2016
@Random-Liu
Copy link
Member Author

@k8s-bot test this issue #22655

@k8s-bot
Copy link

k8s-bot commented May 17, 2016

GCE e2e build/test passed for commit d1ab3b7.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@Random-Liu
Copy link
Member Author

@k8s-bot test this issue #23971

@k8s-bot
Copy link

k8s-bot commented May 17, 2016

GCE e2e build/test passed for commit d1ab3b7.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 7a089c3 into kubernetes:master May 17, 2016
@k8s-bot
Copy link

k8s-bot commented May 17, 2016

GCE e2e build/test passed for commit d1ab3b7.

@Random-Liu Random-Liu deleted the skip-runtime-conformance-test branch May 17, 2016 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants