Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod status/ready/restartCount conformance test #24191

Merged
merged 1 commit into from
May 14, 2016
Merged

Add pod status/ready/restartCount conformance test #24191

merged 1 commit into from
May 14, 2016

Conversation

liangchenye
Copy link
Contributor

add more test cases to cover containers which will be terminated/running/failed/pending.

Signed-off-by: liang chenye [email protected]

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Apr 13, 2016
@liangchenye
Copy link
Contributor Author

@Random-Liu @pwittrock
seperate the conformace_test.go to image_conformance_test.go and runtime_conformance_test.go
add more status test cases.

Describe("container runtime conformance blackbox test", func() {
Context("when start a container that exits success", func() {
var terminateContainers []ConformanceContainer
It("it should run with the expected status [Conformance]", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: Remove "it" from all the It description.

@Random-Liu Random-Liu assigned Random-Liu and unassigned fejta Apr 14, 2016
@liangchenye
Copy link
Contributor Author

Updated
This patch also need to be rebased.
#24329

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2016
@Random-Liu
Copy link
Member

Will review soon.

@pwittrock
Copy link
Member

@liangchenye can you look into the test failures

@pwittrock
Copy link
Member

@liangchenye Also, can you break this PR up into 2 pieces. The first piece should fix the flaky test failures?

@Random-Liu
Copy link
Member

@liangchenye As @pwittrock suggested, it would be better to send a separate PR to fix #24937 first. :)

@liangchenye
Copy link
Contributor Author

liangchenye commented May 4, 2016

split into anther PR #25121

About the test failure, it is a timeout issue: the container is expected to run 3 times, but it fails to accomplish that within 5 minutes. I update by expecting it to restart 1 time.

---- sorry, my fault in the previous commit, it is not timeout issue.

The timeout is unpredictable. How about using 'for loop' instead of 'Eventually'? If we catch a timeout, we could report it as a timeout warning other than a Expect error brought by 'Eventually'.

@liangchenye
Copy link
Contributor Author

@k8s-bot test this issue #24619

k8s-github-robot pushed a commit that referenced this pull request May 6, 2016
Automatic merge from submit-queue

fix #24937:  flake pod not found

#24937
Split from #24191
Signed-off-by: liang chenye <[email protected]>
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2016
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no and removed cla: yes labels May 6, 2016
@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 6, 2016
@liangchenye
Copy link
Contributor Author

@k8s-bot test this issue #24619

@@ -62,37 +65,42 @@ func (matcher *ConformanceContainerEqualMatcher) NegatedFailureMessage(actual in
return format.Message(actual, "not to equal", matcher.Expected)
}

func (cc *ConformanceContainer) SetName(name string) {
cc.Container.Name = name + string(util.NewUUID())
Copy link
Member

@Random-Liu Random-Liu May 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should randomize the pod name, not the container name.

  • We could have different pods with same container name.
  • We could not have pods with the same pod name and namespace.

@Random-Liu Random-Liu added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge release-note-none Denotes a PR that doesn't merit a release note. and removed needs-ok-to-merge labels May 14, 2016
@k8s-bot
Copy link

k8s-bot commented May 14, 2016

GCE e2e build/test passed for commit 4ddb160.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 14, 2016

GCE e2e build/test passed for commit 4ddb160.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit cb9a851 into kubernetes:master May 14, 2016
@ixdy ixdy mentioned this pull request May 17, 2016
k8s-github-robot pushed a commit that referenced this pull request May 17, 2016
Automatic merge from submit-queue

Node E2E: Shorten consistently check timeout of runtime conformance test

#24191 increased the node e2e running time by almost half an hour. It makes the test running time exceed 60 minutes timeout, which causes quite a few issues (See #25639).

As a quite fix, we'll skip all the runtime conformance test. @liangchenye We should remove redundant test cases in #24191 such as #24191 (comment), and reduce the test running time as much as possible.
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Nov 26, 2019
…-release-4.1

Bug 1775757: KubeAPI server doesn't accept large patch requests

Origin-commit: 1a80a974c6c728dc14d9b96c1e2aea274d0b7d22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants