Skip to content

Add verbosity#7514

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
mikesplain:add_bazel_verbose
Sep 3, 2019
Merged

Add verbosity#7514
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
mikesplain:add_bazel_verbose

Conversation

@mikesplain
Copy link
Copy Markdown
Contributor

Add some verbosity to bazel builds.

Includes some python changes from #7508

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2019
@mikesplain
Copy link
Copy Markdown
Contributor Author

Stamp was also deprecated

@rifelpet
Copy link
Copy Markdown
Member

rifelpet commented Sep 3, 2019

I think --stamp was needed based on #7493 (comment)

@mikesplain
Copy link
Copy Markdown
Contributor Author

Good catch, that was a different stamp that was deprecated I think. I'll leave as is for now.

@rifelpet
Copy link
Copy Markdown
Member

rifelpet commented Sep 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 39941ce into kubernetes:master Sep 3, 2019
@mikesplain mikesplain deleted the add_bazel_verbose branch September 4, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants