Update rules_go and gazelle to fix postsubmit job#7493
Update rules_go and gazelle to fix postsubmit job#7493rifelpet wants to merge 2 commits intokubernetes:masterfrom
Conversation
`make bazel-crossbuild-kops` is currently failing [0] due to a bug in rules_go which was fixed [1]. Also updating gazelle while I'm at it. [0] https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/kops-postsubmit/1167506341137223682 [1] bazel-contrib/rules_go#2118
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test pull-kops-e2e-kubernetes-aws |
|
@rifelpet: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Thanks @rifelpet - this is awesome. I think the problem we're both hitting is the problem you pointed out in #7499 (comment) Specifically in this case, https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kops/7493/pull-kops-e2e-kubernetes-aws/1167564372923387907/artifacts/52.212.243.151/kops-configuration.log Note the "protokube:{STABLE_KOPS_VERSION}" instead of a real tag... That in turn is because rules_go 0.19.0 now requires We'll see if that works :-) |
|
Though we're both hitting the same error with rules_go .... I didn't fix the cgo issue you fixed so I think we probably do still need this PR @rifelpet (?) |
make bazel-crossbuild-kopsis currently failing due to a bug in rules_go which was fixed. Also updating gazelle while I'm at it.rules_go 0.19.0 changed cross-compiling to no longer use cgo by default. I'm not sure if we should add the
_cgoplatform suffix to continue with the past behavior or if its fine to not use cgo.I'm hoping this fixes the kops-postsubmit job!