Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use etcd-manager built from etcdadm repo #11098

Merged

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Mar 21, 2021

We can now use etcd-manager as built from the kubernetes-sigs/etcdadm
repo.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2021
@justinsb
Copy link
Member Author

This image is built from https://github.com/kubernetes-sigs/etcdadm . The intent is that we can make that repo the canonical location. Before merging, we want to get the image built using the k8s staging and image promotion systems.

This image is currently built manually, and is just intended to verify that the version built from the new repo works (i.e. that no problems have been introduced in the repo move)

@justinsb justinsb force-pushed the etcd_manager_from_etcdadm_repo branch from 80f7441 to 1133943 Compare April 4, 2021 15:27
@justinsb justinsb force-pushed the etcd_manager_from_etcdadm_repo branch 2 times, most recently from ea21054 to b627fd9 Compare May 2, 2021 14:51
@justinsb
Copy link
Member Author

justinsb commented May 2, 2021

cc @hakman

So I finally got the build working and proposed the latest image for promotion

One thing I realized .... I didn't promote the -amd64 and -arm64 tags. Are these needed? If so I can add them to the process (which is a bit of a WIP) and propose another promotion.

Another snafu is (as you pointed out) that it's not as clear which version we are promoting ... we need to tag in the source repo and/or maybe plumb through the version in something like our versions.go.

@hakman
Copy link
Member

hakman commented May 2, 2021

Thanks @justinsb. This is pretty cool.
There is no need for the -amd64 and the -arm64 tags, at least for us. I don't think we do it for the kOps images either.
Not quite sure what's the best way forward for versions. Tagging in the source repo would be good, but not sure how well this will go long term.

@hakman
Copy link
Member

hakman commented May 2, 2021

Btw, this is ready from my point of view.
After we merge kubernetes-retired/etcdadm#205 we could switch to v3.1.x.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2021
@hakman
Copy link
Member

hakman commented May 2, 2021

/test pull-kops-e2e-k8s-containerd-ha

1 similar comment
@hakman
Copy link
Member

hakman commented May 2, 2021

/test pull-kops-e2e-k8s-containerd-ha

@justinsb justinsb changed the title WIP: Use etcd-manager built from etcdadm repo Use etcd-manager built from etcdadm repo May 7, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2021
@justinsb
Copy link
Member Author

justinsb commented May 7, 2021

As discussed in office hours, the remaining things shouldn't be blockers for kops adoption, so removing WIP

@hakman
Copy link
Member

hakman commented May 7, 2021

Thanks @justinsb. I tracked the commits that removed support for etcd v2 in kOps and we are good later with back-porting to 1.20:
#10141
#10245

@hakman
Copy link
Member

hakman commented May 7, 2021

@justinsb should this also bump the backup image?

justinsb and others added 2 commits May 8, 2021 07:11
We can now use etcd-manager as built from the kubernetes-sigs/etcdadm
repo.
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2021
@hakman hakman closed this May 8, 2021
@hakman hakman reopened this May 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 261a2e9 into kubernetes:master May 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone May 8, 2021
k8s-ci-robot added a commit that referenced this pull request May 8, 2021
…-upstream-release-1.20

Automated cherry pick of #11098: Use etcd-manager built from etcdadm repo
k8s-ci-robot added a commit that referenced this pull request May 8, 2021
…-upstream-release-1.19

Automated cherry pick of #11098: Use etcd-manager built from etcdadm repo
k8s-ci-robot added a commit that referenced this pull request May 8, 2021
…-upstream-release-1.21

Automated cherry pick of #11098: Use etcd-manager built from etcdadm repo
@johngmyers johngmyers modified the milestones: v1.21, v1.22 May 10, 2021
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…-of-#11098-upstream-release-1.19

Automated cherry pick of kubernetes#11098: Use etcd-manager built from etcdadm repo
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…-of-#11098-upstream-release-1.19

Automated cherry pick of kubernetes#11098: Use etcd-manager built from etcdadm repo
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…-of-#11098-upstream-release-1.19

Automated cherry pick of kubernetes#11098: Use etcd-manager built from etcdadm repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants