-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use etcd-manager built from etcdadm repo #11098
Use etcd-manager built from etcdadm repo #11098
Conversation
This image is built from https://github.com/kubernetes-sigs/etcdadm . The intent is that we can make that repo the canonical location. Before merging, we want to get the image built using the k8s staging and image promotion systems. This image is currently built manually, and is just intended to verify that the version built from the new repo works (i.e. that no problems have been introduced in the repo move) |
80f7441
to
1133943
Compare
ea21054
to
b627fd9
Compare
cc @hakman So I finally got the build working and proposed the latest image for promotion One thing I realized .... I didn't promote the -amd64 and -arm64 tags. Are these needed? If so I can add them to the process (which is a bit of a WIP) and propose another promotion. Another snafu is (as you pointed out) that it's not as clear which version we are promoting ... we need to tag in the source repo and/or maybe plumb through the version in something like our versions.go. |
Thanks @justinsb. This is pretty cool. |
Btw, this is ready from my point of view. |
/test pull-kops-e2e-k8s-containerd-ha |
1 similar comment
/test pull-kops-e2e-k8s-containerd-ha |
As discussed in office hours, the remaining things shouldn't be blockers for kops adoption, so removing WIP |
@justinsb should this also bump the backup image? |
We can now use etcd-manager as built from the kubernetes-sigs/etcdadm repo.
b627fd9
to
305e4bb
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-upstream-release-1.20 Automated cherry pick of #11098: Use etcd-manager built from etcdadm repo
…-upstream-release-1.19 Automated cherry pick of #11098: Use etcd-manager built from etcdadm repo
…-upstream-release-1.21 Automated cherry pick of #11098: Use etcd-manager built from etcdadm repo
…-of-#11098-upstream-release-1.19 Automated cherry pick of kubernetes#11098: Use etcd-manager built from etcdadm repo
…-of-#11098-upstream-release-1.19 Automated cherry pick of kubernetes#11098: Use etcd-manager built from etcdadm repo
…-of-#11098-upstream-release-1.19 Automated cherry pick of kubernetes#11098: Use etcd-manager built from etcdadm repo
We can now use etcd-manager as built from the kubernetes-sigs/etcdadm
repo.