Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote etcdadm 3.0.20210430 images #1991

Merged
merged 1 commit into from
May 2, 2021

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented May 1, 2021

Created with:

Propose promotion of artifacts

Create container promotion PR:

gcrane ls gcr.io/k8s-staging-etcdadm/etcd-manager
STAGING_VERSION=v20210430-v0.1.3-739-g7da12acc
RELEASE_VERSION=3.0.20210430
cd ${GOPATH}/src/k8s.io/k8s.io

git checkout main
git pull
git checkout -b etcdadm_images_${RELEASE_VERSION}

cd k8s.gcr.io/images/k8s-staging-etcdadm
echo "" >> images.yaml
echo "# ${RELEASE_VERSION}" >> images.yaml
k8s-container-image-promoter --snapshot gcr.io/k8s-staging-etcdadm --snapshot-tag ${STAGING_VERSION} | sed s@${STAGING_VERSION}@${RELEASE_VERSION}@g >> images.yaml

You can dry-run the promotion with

cd ${GOPATH}/src/k8s.io/k8s.io
k8s-container-image-promoter --thin-manifest-dir k8s.gcr.io

Currently we send the image and non-image artifact promotion PRs separately.

git add -p k8s.gcr.io/images/k8s-staging-etcdadm/images.yaml
git commit -m "Promote etcdadm $RELEASE_VERSION images"
git push ${USER}
hub pull-request -b main

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. wg/k8s-infra labels May 1, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 1, 2021
@dims
Copy link
Member

dims commented May 2, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7edf9bd into kubernetes:main May 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants