-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conversion to OpenShift (invalid DeploymentConfig) #126
Conversation
Mind adding a test to prevent regression? |
@kadel to address this issue in #73 I added a function called This function was created because @ngtuna asked for it #94 (comment) Link to function in diff |
} | ||
//make sure that Serices are first in the List | ||
switch object.(type) { | ||
case *api.Service: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To simplify this switch you can also use object.GetObjectKind().GroupVersionKind().Kind == "Service"
to do the checks.
ah, I missed that, I'll move that function to Kubernetes Transformer and use that |
ec58677
to
1cdfdaf
Compare
add missing conversion to versioned object when saving to files
Sorts objects in Transform function, this should make sure that Services are first everywhere as long as we keep order in the slice that Transform returns. fixes kubernetes#130
1cdfdaf
to
e2da0f0
Compare
+1 looks ok, but did not test |
fixes #124 by add missing conversion to versioned object when saving to files
I've also added commit that fixes #130