Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services should be first in List #130

Closed
kadel opened this issue Aug 30, 2016 · 0 comments · Fixed by #126
Closed

services should be first in List #130

kadel opened this issue Aug 30, 2016 · 0 comments · Fixed by #126

Comments

@kadel
Copy link
Member

kadel commented Aug 30, 2016

When generating List, Services should be first in the List to make sure they are created fist.
kadel added a commit to kadel/kompose that referenced this issue Aug 30, 2016
@kadel
Make sure that Services are first in the List
c6a15c9 
fixes kubernetes#130
@kadel kadel mentioned this issue Aug 30, 2016
Merged
kadel added a commit to kadel/kompose that referenced this issue Aug 30, 2016
@kadel
Make sure that Services are first in the List
ec58677 
Sorts objects in Transform function, this should
make sure that Services are first everywhere as
long as we keep order in the slice that Transform returns.

fixes kubernetes#130
kadel added a commit to kadel/kompose that referenced this issue Aug 30, 2016
@kadel
Make sure that Services are first in the List
1cdfdaf 
Sorts objects in Transform function, this should
make sure that Services are first everywhere as
long as we keep order in the slice that Transform returns.

fixes kubernetes#130
kadel added a commit to kadel/kompose that referenced this issue Aug 30, 2016
@kadel
Make sure that Services are first in the List
c0833e5 
Sorts objects in Transform function, this should
make sure that Services are first everywhere as
long as we keep order in the slice that Transform returns.

fixes kubernetes#130
kadel added a commit to kadel/kompose that referenced this issue Sep 2, 2016
@kadel
Make sure that Services are first in the List
e2da0f0 
Sorts objects in Transform function, this should
make sure that Services are first everywhere as
long as we keep order in the slice that Transform returns.

fixes kubernetes#130
@kadel kadel closed this as completed in #126 Sep 5, 2016
cab105 pushed a commit to cab105/kompose that referenced this issue Oct 27, 2016
@kadel @cab105
Make sure that Services are first in the List
a88d6af 
Sorts objects in Transform function, this should
make sure that Services are first everywhere as
long as we keep order in the slice that Transform returns.

fixes kubernetes#130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix conversion to OpenShift (invalid DeploymentConfig) kadel/kompose
1 participant
@kadel