Use info in default stderrThreshold#42
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Feb 7, 2019
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
vincepri
force-pushed
the
raise-standard-stderr
branch
from
3a8c55a to
b3fc759
Compare
Member
|
/approve let's wait to see if anyone objects for a little bit |
k8s-ci-robot
added
the
approved
Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
raise-standard-stderr
branch
from
b3fc759 to
9e8a655
Compare
neolit123
approved these changes
Feb 5, 2019
Member
neolit123
left a comment
neolit123
left a comment
There was a problem hiding this comment.
LGTM
seems like the right thing to do after the previous PR.
Member
Author
|
@dims Should we merge this? I'm eager to update some repos and cleanup init(s). |
Member
|
go for it @vincepri /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
This PR is a follow-up to #39, it sets the default threshold for stderr logging to
INFO.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: