Stderr threshold issue fix by pierluigilenoci · Pull Request #221 · kubernetes/klog

pierluigilenoci · 2021-03-09T16:56:31Z

What this PR does / why we need it:

This is my proposal to address these issues: #54 and #21

History of this bug:
#31
#42
#50

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #212

Special notes for your reviewer:

I added a further flag to decouple the behaviors between alsoToStderr and the default level of toStderr.

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

k8s-ci-robot · 2021-03-09T16:56:39Z

Welcome @pierluigilenoci!

It looks like this is your first PR to kubernetes/klog 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/klog has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-03-09T16:56:42Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pierluigilenoci
To complete the pull request process, please assign brancz after the PR has been reviewed.
You can assign the PR to them by writing /assign @brancz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

neolit123 · 2021-03-09T17:10:41Z

 //	-alsologtostderr=false
 //		Logs are written to standard error as well as to files.
-//	-stderrthreshold=ERROR
+//	-stderrthreshold=INFO


this might have to land in new release because it's a breaking change.

Please check the change inside the code. This is to maintain the pre-existing behavior.
However, there are no problems to land in a release.

neolit123 · 2021-03-09T17:11:13Z

 	flagset.BoolVar(&logging.oneOutput, "one_output", logging.oneOutput, "If true, only write logs to their native severity level (vs also writing to each lower severity level)")
 	flagset.BoolVar(&logging.skipLogHeaders, "skip_log_headers", logging.skipLogHeaders, "If true, avoid headers when opening log files")
 	flagset.Var(&logging.stderrThreshold, "stderrthreshold", "logs at or above this threshold go to stderr")
+	flagset.Var(&logging.alsoToStderrThreshold, "alsotostderrthreshold", "logs at or above this threshold go to stderr as well as files")


i personally find the new flag confusing but i can see you are trying to fix an already confusing behavior with it.

I see no other way to fix this without breaking the old installations.

neolit123 · 2021-03-09T17:24:52Z

cc @kubernetes/sig-instrumentation-approvers

Ref: #54 #212 #31 #42 #50

k8s-triage-robot · 2021-08-31T18:12:25Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pierluigilenoci · 2021-09-01T06:30:56Z

/remove-lifecycle stale

k8s-triage-robot · 2021-11-30T07:30:56Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pierluigilenoci · 2021-12-02T16:44:35Z

/remove-lifecycle stale

k8s-ci-robot · 2022-02-15T00:15:03Z

@pierluigilenoci: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pohly · 2022-04-04T08:34:54Z

Please add a release note that summarizes the problem and your solution.

pohly · 2022-04-04T08:38:22Z

Your current PR commits and descriptions assume that a reviewer is familiar with the problem or has the time to re-read all the prior issues. Can you make this easier to review by following https://www.kubernetes.dev/docs/guide/pull-requests/#commit-message-guidelines?

I think you can also squash all of your commits.

k8s-triage-robot · 2022-07-03T09:53:16Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

pierluigilenoci · 2022-07-04T11:52:13Z

This is still an issue

pohly · 2022-07-04T12:46:25Z

This is still an issue

So do you intend to get the PR into a mergeable state as discussed in the issue?

pierluigilenoci · 2022-07-04T15:08:02Z

@pohly this is the plan. To be implemented in the near future. 🚀
Unless someone else feels brave enough to want to do it. 😝

k8s-triage-robot · 2022-08-03T15:59:08Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

pierluigilenoci · 2022-08-04T07:35:06Z

/remove-lifecycle rotten

pohly · 2022-08-22T13:37:52Z

@pierluigilenoci: this has been pending a long time. I am going to close it now to clean up pending PRs. Please reopen when there is something that is ready for merging.

/close

k8s-ci-robot · 2022-08-22T13:38:14Z

@pohly: Closed this PR.

Details

In response to this:

@pierluigilenoci: this has been pending a long time. I am going to close it now to clean up pending PRs. Please reopen when there is something that is ready for merging.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2021

k8s-ci-robot requested review from neolit123 and yagonobre March 9, 2021 16:56

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2021

neolit123 reviewed Mar 9, 2021

View reviewed changes

Pierluigi Lenoci added 2 commits March 10, 2021 09:36

Added alsotostderrthreshold options and fixed StderrThreshold issue

1d97b27

Ref: #54 #212 #31 #42 #50

new parameter inside the test (test needs to be fixed)

6f2fbaa

pierluigilenoci force-pushed the stderrthreshold_fix branch from fc6e969 to 6f2fbaa Compare March 10, 2021 08:37

test in this way

28c2619

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 31, 2021

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 30, 2021

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 2, 2021

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 3, 2022

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 4, 2022

k8s-ci-robot closed this Aug 22, 2022

pierluigilenoci mentioned this pull request Dec 15, 2025

feat: fix stderrthreshold not honored when logtostderr is set (#212) + two new flags #432

Merged

Conversation

pierluigilenoci commented Mar 9, 2021

Uh oh!

k8s-ci-robot commented Mar 9, 2021

Uh oh!

k8s-ci-robot commented Mar 9, 2021

Uh oh!

neolit123 Mar 9, 2021

Choose a reason for hiding this comment

Uh oh!

pierluigilenoci Mar 9, 2021

Choose a reason for hiding this comment

Uh oh!

neolit123 Mar 9, 2021

Choose a reason for hiding this comment

Uh oh!

pierluigilenoci Mar 9, 2021

Choose a reason for hiding this comment

Uh oh!

neolit123 commented Mar 9, 2021

Uh oh!

k8s-triage-robot commented Aug 31, 2021

Uh oh!

pierluigilenoci commented Sep 1, 2021

Uh oh!

k8s-triage-robot commented Nov 30, 2021

Uh oh!

pierluigilenoci commented Dec 2, 2021

Uh oh!

k8s-ci-robot commented Feb 15, 2022

Uh oh!

pohly commented Apr 4, 2022

Uh oh!

pohly commented Apr 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-triage-robot commented Jul 3, 2022

Uh oh!

pierluigilenoci commented Jul 4, 2022

Uh oh!

pohly commented Jul 4, 2022

Uh oh!

pierluigilenoci commented Jul 4, 2022

Uh oh!

k8s-triage-robot commented Aug 3, 2022

Uh oh!

pierluigilenoci commented Aug 4, 2022

Uh oh!

pohly commented Aug 22, 2022

Uh oh!

k8s-ci-robot commented Aug 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pohly commented Apr 4, 2022 •

edited

Loading