Skip to content

audit: update as of 2021-09-09#2689

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
k8s-infra-ci-robot:autoaudit-prow
Sep 9, 2021
Merged

audit: update as of 2021-09-09#2689
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
k8s-infra-ci-robot:autoaudit-prow

Conversation

@k8s-infra-ci-robot
Copy link
Copy Markdown
Contributor

Audit Updates wg-k8s-infra

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/audit Audit of project resources, audit followup issues, code in audit/ wg/k8s-infra labels Sep 9, 2021
@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Sep 9, 2021

I think this is stale vs. what's in the repo, waiting for next run

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2021
Time updated: Thu, 09 Sep 2021 01:48:27 GMT
Metageneration: 34
Bucket Policy Only enabled: True
Public access prevention: unspecified
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this seems new

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Comment on lines +2 to +10
"bindings": [
{
"members": [
"projectEditor:k8s-staging-cloud-provider-ibm",
"projectOwner:k8s-staging-cloud-provider-ibm"
],
"role": "roles/storage.legacyBucketOwner"
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected, this was #2618 (comment)

Comment on lines +1 to +11
{
"createTime": "2021-09-09T13:31:52.066Z",
"lifecycleState": "ACTIVE",
"name": "k8s-staging-sched-simulator",
"parent": {
"id": "758905017065",
"type": "organization"
},
"projectId": "k8s-staging-sched-simulator",
"projectNumber": "575095402180"
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected, this was #2681 getting deployed

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2021
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@@ -1,7 +1,6 @@
NAME TITLE
cloudbuild.googleapis.com Cloud Build API
cloudkms.googleapis.com Cloud Key Management Service (KMS) API
containeranalysis.googleapis.com Container Analysis API
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected, this was mid-way through its scan of projects when I ran #1963 (comment)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-ci-robot, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fcf726e into kubernetes:main Sep 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit Audit of project resources, audit followup issues, code in audit/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants