Skip to content

For pushing ibm-vpc-csi-driver images#2618

Merged
k8s-ci-robot merged 4 commits intokubernetes:mainfrom
ambiknai:main
Sep 8, 2021
Merged

For pushing ibm-vpc-csi-driver images#2618
k8s-ci-robot merged 4 commits intokubernetes:mainfrom
ambiknai:main

Conversation

@ambiknai
Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects labels Aug 26, 2021
@k8s-ci-robot k8s-ci-robot added area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ area/k8s.gcr.io Code in k8s.gcr.io/ wg/k8s-infra labels Aug 26, 2021
@ambiknai
Copy link
Copy Markdown
Contributor Author

@nikhita @thockin Not sure the reason for below error

Could not load groups config: couldn't merge groups: cannot define group "k8s-infra-staging-cloud-provider-ibm@kubernetes.io" in "groups.yaml"
29
exit status 1
30
FAIL	k8s.io/k8s.io/groups	0.020s

Could you please help me find what went wring in the commit

@ambiknai ambiknai closed this Aug 26, 2021
@ambiknai ambiknai reopened this Sep 6, 2021
@ambiknai
Copy link
Copy Markdown
Contributor Author

ambiknai commented Sep 6, 2021

@ameukam @cblecker @spiffxp Could some one please review and merge this PR

k8s-staging-storage-migrator:
k8s-staging-test-infra:
k8s-staging-txtdirect:
k8s-staging-cloud-provider-ibm:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ambiknai Please, respect the alphabetic order of this list.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved it as per this comment.

@ameukam
Copy link
Copy Markdown
Member

ameukam commented Sep 7, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2021
@ambiknai
Copy link
Copy Markdown
Contributor Author

ambiknai commented Sep 7, 2021

/assign @cblecker

@arahamad-zz
Copy link
Copy Markdown

/lgtm

@arahamad-zz
Copy link
Copy Markdown

/approve

Copy link
Copy Markdown
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ambiknai, ameukam, arahamad, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit fc60c86 into kubernetes:main Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 8, 2021
@ambiknai
Copy link
Copy Markdown
Contributor Author

ambiknai commented Sep 9, 2021

@spiffxp Thanks for approving the PR
I could not see the project when I checked Google Cloud Dashboard.

@ameukam
Copy link
Copy Markdown
Member

ameukam commented Sep 9, 2021

@ambiknai
Copy link
Copy Markdown
Contributor Author

ambiknai commented Sep 9, 2021

@ameukam shouldnt it be k8s-staging-cloud-provider-ibm

Not sure if I missed something here. I just changed the above url to point to k8s-staging-cloud-provider-ibm project and it says permission denied

Screenshot 2021-09-09 at 9 45 31 AM

@ameukam
Copy link
Copy Markdown
Member

ameukam commented Sep 9, 2021

@ameukam shouldnt it be k8s-staging-cloud-provider-ibm

Not sure if I missed something here. I just changed the above url to point to k8s-staging-cloud-provider-ibm project and it says permission denied

Screenshot 2021-09-09 at 9 45 31 AM

@ambiknai Sorry wrong project ID: https://console.cloud.google.com/home/dashboard?project=k8s-staging-cloud-provider-ibm.

@ambiknai
Copy link
Copy Markdown
Contributor Author

ambiknai commented Sep 9, 2021

@ameukam shouldnt it be k8s-staging-cloud-provider-ibm
Not sure if I missed something here. I just changed the above url to point to k8s-staging-cloud-provider-ibm project and it says permission denied
Screenshot 2021-09-09 at 9 45 31 AM

@ambiknai Sorry wrong project ID: https://console.cloud.google.com/home/dashboard?project=k8s-staging-cloud-provider-ibm.

But I dont have permission as shared in screenshot.

@ameukam
Copy link
Copy Markdown
Member

ameukam commented Sep 9, 2021

Forgot to mention earlier I ran ./ensure-staging-storage.sh k8s-staging-cloud-provider-ibm instead of
./ensure-staging-storage.sh cloud-provider-ibm.

It's possible the groups reconciliation didn't happen for k8s-infra-staging-cloud-provider-ibm@kubernetes.io.

@ambiknai
Copy link
Copy Markdown
Contributor Author

ambiknai commented Sep 9, 2021

@ameukam Ok. So how can this be fixed. I still don't see project in my dashboard

@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Sep 9, 2021

Somehow when I ran ./infra/gcp/bash/ensure-staging-storage.sh cloud-provider-ibm when this PR merged it failed out at GCR repo creation.

I'm re-running for all staging projects now just to make sure everything is up to date, and I caught this. You should be good to go now

Configuring staging project: k8s-staging-cloud-provider-ibm
  Ensuring project exists: k8s-staging-cloud-provider-ibm
  Ensuring k8s-infra-staging-cloud-provider-ibm@kubernetes.io are project viewers
  Ensuring necessary enabled services staging project: k8s-staging-cloud-provider-ibm
  Ensuring disabled services for staging project: k8s-staging-cloud-provider-ibm
  Ensuring serviceAccount:k8s-infra-gcr-vuln-scanning@k8s-artifacts-prod.iam.gserviceaccount.com can view vulnernability scanning results for project: k8s-staging-cloud-provider-ibm
  Ensuring staging GCR repo: gcr.io/k8s-staging-cloud-provider-ibm
    Ensuring a GCR repo exists for project: k8s-staging-cloud-provider-ibm
    Using default tag: latest
    latest: Pulling from pause
    Digest: sha256:a78c2d6208eff9b672de43f880093100050983047b7b0afe0217d3656e1b0d5f
    Status: Image is up to date for k8s.gcr.io/pause:latest
    k8s.gcr.io/pause:latest
    Using default tag: latest
    The push refers to repository [gcr.io/k8s-staging-cloud-provider-ibm/ceci-nest-pas-une-image]
    5f70bf18a086: Preparing
    e16a89738269: Preparing
    5f70bf18a086: Preparing
    5f70bf18a086: Layer already exists
    e16a89738269: Layer already exists
    latest: digest: sha256:ec3ca3ee90e4dafde96c83232b30f17b5e8992ff35479d0661b8f4ff2f21bf74 size: 938
    Digests:
    - gcr.io/k8s-staging-cloud-provider-ibm/ceci-nest-pas-une-image@sha256:ec3ca3ee90e4dafde96c83232b30f17b5e8992ff35479d0661b8f4ff2f21bf74
      Associated tags:
     - latest
    Tags:
    - gcr.io/k8s-staging-cloud-provider-ibm/ceci-nest-pas-une-image:latest
    Deleted [gcr.io/k8s-staging-cloud-provider-ibm/ceci-nest-pas-une-image:latest].
    Deleted [gcr.io/k8s-staging-cloud-provider-ibm/ceci-nest-pas-une-image@sha256:ec3ca3ee90e4dafde96c83232b30f17b5e8992ff35479d0661b8f4ff2f21bf74].
    Enabling Bucket Policy Only for gs://artifacts.k8s-staging-cloud-provider-ibm.appspot.com...
    @@ -1,3 +1,5 @@
    +- member: allUsers
    +  role: roles/storage.objectViewer
     - member: projectEditor:k8s-staging-cloud-provider-ibm
       role: roles/storage.legacyBucketOwner
     - member: projectOwner:k8s-staging-cloud-provider-ibm
    Ensuring k8s-infra-staging-cloud-provider-ibm@kubernetes.io can write to GCR for project: k8s-staging-cloud-provider-ibm
    @@ -1,5 +1,7 @@
     - member: allUsers
       role: roles/storage.objectViewer
    +- member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
    +  role: roles/storage.objectAdmin
     - member: projectEditor:k8s-staging-cloud-provider-ibm
       role: roles/storage.legacyBucketOwner
     - member: projectOwner:k8s-staging-cloud-provider-ibm
    @@ -1,5 +1,7 @@
     - member: allUsers
       role: roles/storage.objectViewer
    +- member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
    +  role: roles/storage.legacyBucketWriter
     - member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
       role: roles/storage.objectAdmin
     - member: projectEditor:k8s-staging-cloud-provider-ibm
    Ensuring GCR admins can admin GCR for project: k8s-staging-cloud-provider-ibm
    Updated IAM policy for project [k8s-staging-cloud-provider-ibm].
    @@ -1,3 +1,5 @@
    +- member: group:k8s-infra-artifact-admins@kubernetes.io
    +  role: roles/viewer
     - member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
       role: roles/viewer
     - member: serviceAccount:708000853573@cloudbuild.gserviceaccount.com
    @@ -1,5 +1,7 @@
     - member: allUsers
       role: roles/storage.objectViewer
    +- member: group:k8s-infra-artifact-admins@kubernetes.io
    +  role: roles/storage.objectAdmin
     - member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
       role: roles/storage.legacyBucketWriter
     - member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
    @@ -1,5 +1,7 @@
     - member: allUsers
       role: roles/storage.objectViewer
    +- member: group:k8s-infra-artifact-admins@kubernetes.io
    +  role: roles/storage.legacyBucketOwner
     - member: group:k8s-infra-artifact-admins@kubernetes.io
       role: roles/storage.objectAdmin
     - member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
    Ensuring GCS access logs enabled for GCR bucket in project: k8s-staging-cloud-provider-ibm
    Enabling logging on gs://artifacts.k8s-staging-cloud-provider-ibm.appspot.com/...
    @@ -1 +1 @@
    -gs://artifacts.k8s-staging-cloud-provider-ibm.appspot.com/ has no logging configuration.
    +{"logBucket": "k8s-infra-artifacts-gcslogs", "logObjectPrefix": "artifacts.k8s-staging-cloud-provider-ibm.appspot.com"}
  Ensuring staging GCS bucket: gs://k8s-staging-cloud-provider-ibm
    Ensuring gs://k8s-staging-cloud-provider-ibm exists and is world readable in project: k8s-staging-cloud-provider-ibm
    Creating gs://k8s-staging-cloud-provider-ibm/...
    Enabling Bucket Policy Only for gs://k8s-staging-cloud-provider-ibm...
    @@ -1,3 +1,5 @@
    +- member: allUsers
    +  role: roles/storage.objectViewer
     - member: projectEditor:k8s-staging-cloud-provider-ibm
       role: roles/storage.legacyBucketOwner
     - member: projectOwner:k8s-staging-cloud-provider-ibm
    Ensuring gs://k8s-staging-cloud-provider-ibm has auto-deletion of 60 days
    Setting lifecycle configuration on gs://k8s-staging-cloud-provider-ibm/...
    @@ -1 +1 @@
    -gs://k8s-staging-cloud-provider-ibm/ has no lifecycle configuration.
    +{"rule": [{"action": {"type": "Delete"}, "condition": {"age": 60}}]}
    Ensuring GCS admins can admin gs://k8s-staging-cloud-provider-ibm in project: k8s-staging-cloud-provider-ibm
    @@ -1,5 +1,7 @@
     - member: allUsers
       role: roles/storage.objectViewer
    +- member: group:k8s-infra-artifact-admins@kubernetes.io
    +  role: roles/storage.objectAdmin
     - member: projectEditor:k8s-staging-cloud-provider-ibm
       role: roles/storage.legacyBucketOwner
     - member: projectOwner:k8s-staging-cloud-provider-ibm
    @@ -1,5 +1,7 @@
     - member: allUsers
       role: roles/storage.objectViewer
    +- member: group:k8s-infra-artifact-admins@kubernetes.io
    +  role: roles/storage.legacyBucketOwner
     - member: group:k8s-infra-artifact-admins@kubernetes.io
       role: roles/storage.objectAdmin
     - member: projectEditor:k8s-staging-cloud-provider-ibm
    Ensuring k8s-infra-staging-cloud-provider-ibm@kubernetes.io can write to gs://k8s-staging-cloud-provider-ibm in project: k8s-staging-cloud-provider-ibm
    @@ -4,6 +4,8 @@
       role: roles/storage.legacyBucketOwner
     - member: group:k8s-infra-artifact-admins@kubernetes.io
       role: roles/storage.objectAdmin
    +- member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
    +  role: roles/storage.objectAdmin
     - member: projectEditor:k8s-staging-cloud-provider-ibm
       role: roles/storage.legacyBucketOwner
     - member: projectOwner:k8s-staging-cloud-provider-ibm
    @@ -4,6 +4,8 @@
       role: roles/storage.legacyBucketOwner
     - member: group:k8s-infra-artifact-admins@kubernetes.io
       role: roles/storage.objectAdmin
    +- member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
    +  role: roles/storage.legacyBucketWriter
     - member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
       role: roles/storage.objectAdmin
     - member: projectEditor:k8s-staging-cloud-provider-ibm
    Ensuring GCS access logs enabled for gs://k8s-staging-cloud-provider-ibm in project: k8s-staging-cloud-provider-ibm
    Enabling logging on gs://k8s-staging-cloud-provider-ibm/...
    @@ -1 +1 @@
    -gs://k8s-staging-cloud-provider-ibm/ has no logging configuration.
    +{"logBucket": "k8s-infra-artifacts-gcslogs", "logObjectPrefix": "k8s-staging-cloud-provider-ibm"}
  Ensuring staging GCB
    Ensuring staging bucket: gs://k8s-staging-cloud-provider-ibm-gcb
      Ensuring gs://k8s-staging-cloud-provider-ibm-gcb exists and is world readable in project: k8s-staging-cloud-provider-ibm
      Creating gs://k8s-staging-cloud-provider-ibm-gcb/...
      Enabling Bucket Policy Only for gs://k8s-staging-cloud-provider-ibm-gcb...
      @@ -1,3 +1,5 @@
      +- member: allUsers
      +  role: roles/storage.objectViewer
       - member: projectEditor:k8s-staging-cloud-provider-ibm
         role: roles/storage.legacyBucketOwner
       - member: projectOwner:k8s-staging-cloud-provider-ibm
      Ensuring gs://k8s-staging-cloud-provider-ibm-gcb has auto-deletion of 60 days
      Setting lifecycle configuration on gs://k8s-staging-cloud-provider-ibm-gcb/...
      @@ -1 +1 @@
      -gs://k8s-staging-cloud-provider-ibm-gcb/ has no lifecycle configuration.
      +{"rule": [{"action": {"type": "Delete"}, "condition": {"age": 60}}]}
      Ensuring GCS admins can admin gs://k8s-staging-cloud-provider-ibm-gcb in project: k8s-staging-cloud-provider-ibm
      @@ -1,5 +1,7 @@
       - member: allUsers
         role: roles/storage.objectViewer
      +- member: group:k8s-infra-artifact-admins@kubernetes.io
      +  role: roles/storage.objectAdmin
       - member: projectEditor:k8s-staging-cloud-provider-ibm
         role: roles/storage.legacyBucketOwner
       - member: projectOwner:k8s-staging-cloud-provider-ibm
      @@ -1,5 +1,7 @@
       - member: allUsers
         role: roles/storage.objectViewer
      +- member: group:k8s-infra-artifact-admins@kubernetes.io
      +  role: roles/storage.legacyBucketOwner
       - member: group:k8s-infra-artifact-admins@kubernetes.io
         role: roles/storage.objectAdmin
       - member: projectEditor:k8s-staging-cloud-provider-ibm
      Ensuring k8s-infra-staging-cloud-provider-ibm@kubernetes.io can write to gs://k8s-staging-cloud-provider-ibm-gcb in project: k8s-staging-cloud-provider-ibm
      @@ -4,6 +4,8 @@
         role: roles/storage.legacyBucketOwner
       - member: group:k8s-infra-artifact-admins@kubernetes.io
         role: roles/storage.objectAdmin
      +- member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
      +  role: roles/storage.objectAdmin
       - member: projectEditor:k8s-staging-cloud-provider-ibm
         role: roles/storage.legacyBucketOwner
       - member: projectOwner:k8s-staging-cloud-provider-ibm
      @@ -4,6 +4,8 @@
         role: roles/storage.legacyBucketOwner
       - member: group:k8s-infra-artifact-admins@kubernetes.io
         role: roles/storage.objectAdmin
      +- member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
      +  role: roles/storage.legacyBucketWriter
       - member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
         role: roles/storage.objectAdmin
       - member: projectEditor:k8s-staging-cloud-provider-ibm
    Ensuring k8s-infra-staging-cloud-provider-ibm@kubernetes.io can use GCB in project: k8s-staging-cloud-provider-ibm
    Updated IAM policy for project [k8s-staging-cloud-provider-ibm].
    @@ -1,5 +1,7 @@
     - member: group:k8s-infra-artifact-admins@kubernetes.io
       role: roles/viewer
    +- member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
    +  role: roles/cloudbuild.builds.editor
     - member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
       role: roles/viewer
     - member: serviceAccount:708000853573@cloudbuild.gserviceaccount.com
    Updated IAM policy for project [k8s-staging-cloud-provider-ibm].
    @@ -2,6 +2,8 @@
       role: roles/viewer
     - member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
       role: roles/cloudbuild.builds.editor
    +- member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
    +  role: roles/serviceusage.serviceUsageConsumer
     - member: group:k8s-infra-staging-cloud-provider-ibm@kubernetes.io
       role: roles/viewer
     - member: serviceAccount:708000853573@cloudbuild.gserviceaccount.com
    Ensuring gcb-builder@k8s-infra-prow-build-trusted.iam.gserviceaccount.com can use GCB in project: k8s-staging-cloud-provider-ibm
    Updated IAM policy for project [k8s-staging-cloud-provider-ibm].
    @@ -8,6 +8,8 @@
       role: roles/viewer
     - member: serviceAccount:708000853573@cloudbuild.gserviceaccount.com
       role: roles/cloudbuild.builds.builder
    +- member: serviceAccount:gcb-builder@k8s-infra-prow-build-trusted.iam.gserviceaccount.com
    +  role: roles/cloudbuild.builds.builder
     - member: serviceAccount:k8s-infra-gcr-vuln-scanning@k8s-artifacts-prod.iam.gserviceaccount.com
       role: roles/containeranalysis.occurrences.viewer
     - member: serviceAccount:service-708000853573@containerregistry.iam.gserviceaccount.com
    @@ -14,3 +14,5 @@
       role: roles/storage.legacyBucketOwner
     - member: projectViewer:k8s-staging-cloud-provider-ibm
       role: roles/storage.legacyBucketReader
    +- member: serviceAccount:gcb-builder@k8s-infra-prow-build-trusted.iam.gserviceaccount.com
    +  role: roles/storage.objectCreator
    @@ -16,3 +16,5 @@
       role: roles/storage.legacyBucketReader
     - member: serviceAccount:gcb-builder@k8s-infra-prow-build-trusted.iam.gserviceaccount.com
       role: roles/storage.objectCreator
    +- member: serviceAccount:gcb-builder@k8s-infra-prow-build-trusted.iam.gserviceaccount.com
    +  role: roles/storage.objectViewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ area/k8s.gcr.io Code in k8s.gcr.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants