Skip to content

Update snyk ExternalSecret CR name per DNS-1123#2227

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
navidshaikh:pr/fix-sec-name
Jun 15, 2021
Merged

Update snyk ExternalSecret CR name per DNS-1123#2227
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
navidshaikh:pr/fix-sec-name

Conversation

@navidshaikh
Copy link
Copy Markdown
Contributor

@navidshaikh navidshaikh commented Jun 15, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra labels Jun 15, 2021
@k8s-ci-robot k8s-ci-robot requested review from chases2 and spiffxp June 15, 2021 21:45
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 15, 2021
@navidshaikh navidshaikh mentioned this pull request Jun 15, 2021
Merged
spiffxp
spiffxp approved these changes Jun 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit fc2363a into kubernetes:main Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 15, 2021
@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Jun 15, 2021

followup to #2222

@spiffxp spiffxp mentioned this pull request Jun 15, 2021
Merged
@navidshaikh navidshaikh deleted the pr/fix-sec-name branch June 15, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chases2 chases2 Awaiting requested review from chases2

1 more reviewer

@spiffxp spiffxp spiffxp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spiffxp spiffxp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

3 participants

@navidshaikh @k8s-ci-robot @spiffxp