Skip to content

prow: add snyk_token ExternalSecret#2222

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
spiffxp:external-secrets-snyk_token
Jun 15, 2021
Merged

prow: add snyk_token ExternalSecret#2222
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
spiffxp:external-secrets-snyk_token

Conversation

@spiffxp
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp commented Jun 15, 2021

Supercedes kubernetes/test-infra#22298

Secret used by job in kubernetes/test-infra#22293

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 15, 2021
@spiffxp
Copy link
Copy Markdown
Contributor Author

spiffxp commented Jun 15, 2021

/cc @navidshaikh

spec:
backendType: gcpSecretsManager
data:
- key: snyk-token # The name of the GSM Secret
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @spiffxp !

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 15, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 021aba3 into kubernetes:main Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 15, 2021
@spiffxp
Copy link
Copy Markdown
Contributor Author

spiffxp commented Jun 15, 2021

Moving to ExternalSecrets ref: #2220

@spiffxp spiffxp deleted the external-secrets-snyk_token branch June 15, 2021 20:58
@spiffxp
Copy link
Copy Markdown
Contributor Author

spiffxp commented Jun 15, 2021

We could have caught this in a presubmit I think... snyk_token is an invalid secret name, we found this out at deploy time

Fixed in followup #2227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants