prow: switch cncf-ci-github-token to ExternalSecret#2219
Merged
k8s-ci-robot merged 5 commits intokubernetes:mainfrom Jun 15, 2021
Merged
prow: switch cncf-ci-github-token to ExternalSecret#2219k8s-ci-robot merged 5 commits intokubernetes:mainfrom
k8s-ci-robot merged 5 commits intokubernetes:mainfrom
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/audit
specifically cncf-ci-github-token in test-pods namespace
spiffxp
force-pushed
the
external-secrets-audit-token
branch
from
70b9a2c to
b6e92b6
Compare
k8s-ci-robot
added
size/M
spiffxp
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
30 tasks
Contributor
Author
|
Migrating secrets ref: #2220 |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the cncf-ci-github-token Kubernetes
Secretused by the ci-k8sio-audit job to anExternalSecret.This let me uncover a few things:
prow-build-trustedsetup the same way asprow-buildfor accesskubernetes-external-secretsservice account setup{namespace}-{resource}.yamlconvention forserviceaccountsandexternalsecretsEverything here has already been deployed
I exercised by changing the secret value to "monkeys" and seeing the change reflected in-cluster, before changing back.