Skip to content

audit: update as of 2021-06-15#2213

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
cncf-ci:autoaudit-prow
Jun 15, 2021
Merged

audit: update as of 2021-06-15#2213
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
cncf-ci:autoaudit-prow

Conversation

@cncf-ci
Copy link
Copy Markdown
Contributor

@cncf-ci cncf-ci commented Jun 14, 2021

Audit Updates wg-k8s-infra

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 14, 2021

Hi @cncf-ci. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 14, 2021
@k8s-ci-robot k8s-ci-robot requested review from nikhita and spiffxp June 14, 2021 19:01
@k8s-ci-robot k8s-ci-robot added area/audit Audit of project resources, audit followup issues, code in audit/ wg/k8s-infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 14, 2021
ameukam
ameukam reviewed Jun 14, 2021
View reviewed changes
audit/projects/k8s-infra-public-pii/services/bigquery/bigquery.datasets.json
[
{
"kind": "bigquery#dataset",
"id": "k8s-infra-public-pii:k8s_infra_artifacts_gcslogs",
Copy link
Copy Markdown
Member

@ameukam ameukam Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected by #2031

ameukam
ameukam reviewed Jun 14, 2021
View reviewed changes
...infra-public-pii/services/bigquery/bigquery.datasets.k8s_infra_artifacts_gcslogs.access.json
Comment on lines +3 to +16
"role": "WRITER",
"specialGroup": "projectWriters"
},
{
"role": "OWNER",
"specialGroup": "projectOwners"
},
{
"role": "OWNER",
"userByEmail": "ameukam@gmail.com"
},
{
"role": "READER",
"specialGroup": "projectReaders"
Copy link
Copy Markdown
Member

@ameukam ameukam Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected by #2031

ameukam
ameukam reviewed Jun 14, 2021
View reviewed changes
audit/projects/k8s-infra-public-pii/services/enabled.txt
storage-component.googleapis.com Cloud Storage
NAME TITLE
bigquery.googleapis.com BigQuery API
bigquerydatatransfer.googleapis.com BigQuery Data Transfer API
Copy link
Copy Markdown
Member

@ameukam ameukam Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected by #2031

ameukam
ameukam reviewed Jun 14, 2021
View reviewed changes
audit/projects/kubernetes-public/buckets/k8s-infra-tf-public-pii/metadata.txt
@@ -0,0 +1,18 @@
gs://k8s-infra-tf-public-pii/ :
Copy link
Copy Markdown
Member

@ameukam ameukam Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected by #2031

@cncf-ci cncf-ci changed the title audit: update as of 2021-06-14 audit: update as of 2021-06-15 Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 15, 2021
spiffxp
spiffxp approved these changes Jun 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/ok-to-test

audit/projects/k8s-infra-prow-build-trusted/secrets/snyk-token/versions.json
Comment on lines +11 to +18
{
"createTime": "2021-06-15T18:17:20.453869Z",
"etag": "\"15c4d1fc1bf8ed\"",
"name": "projects/180382678033/secrets/snyk-token/versions/1",
"replicationStatus": {
"automatic": {}
},
"state": "ENABLED"
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing related to #2219

audit/projects/k8s-infra-prow-build-trusted/services/container/clusters/prow-build-trusted.json
"masterAuthorizedNetworksConfig": {
"enabled": true
},
"masterAuthorizedNetworksConfig": {},
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected, this was #2219

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cncf-ci, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3295d4b into kubernetes:main Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ameukam ameukam ameukam left review comments

@nikhita nikhita Awaiting requested review from nikhita

+1 more reviewer

@spiffxp spiffxp spiffxp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spiffxp spiffxp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit Audit of project resources, audit followup issues, code in audit/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

4 participants

@cncf-ci @k8s-ci-robot @spiffxp @ameukam