infra/clusters: use teraform 0.14#2019
Merged
k8s-ci-robot merged 2 commits intokubernetes:mainfrom May 7, 2021
Merged
Conversation
Contributor
Author
|
/cc @ameukam |
Contributor
Author
|
/uncc @alejandrox1 |
Member
|
Ran No changes as expected. /lgtm |
ameukam
approved these changes
May 7, 2021
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced May 10, 2021
|
Followed by #2217 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of issue to upgrade the version of terraform used by our modules: #2020
The upgrade guide looked significantly less scary, given that we aren't doing anything too complex: https://www.terraform.io/upgrade-guides/0-14.html
This was the only thing that jumped out at me, and we have done this by way of deploying the last few PRs
I'm interested in this bump for three reasons:
To verify this:
I have not run
terraform applyfor any of these. Up to you whether this should happen prior to merge, or post-merge