Skip to content

infra/clusters: use teraform 0.14#2019

Merged
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
spiffxp:bump-tf-version
May 7, 2021
Merged

infra/clusters: use teraform 0.14#2019
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
spiffxp:bump-tf-version

Conversation

@spiffxp
Copy link
Contributor

@spiffxp spiffxp commented May 7, 2021

Part of issue to upgrade the version of terraform used by our modules: #2020

The upgrade guide looked significantly less scary, given that we aren't doing anything too complex: https://www.terraform.io/upgrade-guides/0-14.html

You will need to successfully complete a terraform apply at least once under Terraform v0.13 before upgrading an existing configuration to Terraform v0.14.

This was the only thing that jumped out at me, and we have done this by way of deploying the last few PRs

I'm interested in this bump for three reasons:

  • to get us one step closer to the latest release
  • to be able to use dependency lock files
  • to be able to use sensitive values in plan output (e.g. if we wanted something to run plan as a part of a presubmit...)

To verify this:

terraform init
terraform plan
# 0 changes expected

I have not run terraform apply for any of these. Up to you whether this should happen prior to merge, or post-merge

@k8s-ci-robot k8s-ci-robot added the area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters label May 7, 2021
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. wg/k8s-infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2021
@spiffxp
Copy link
Contributor Author

spiffxp commented May 7, 2021

/cc @ameukam

@k8s-ci-robot k8s-ci-robot requested a review from ameukam May 7, 2021 18:13
@spiffxp
Copy link
Contributor Author

spiffxp commented May 7, 2021

/uncc @alejandrox1

@k8s-ci-robot k8s-ci-robot removed the request for review from alejandrox1 May 7, 2021 18:13
@ameukam
Copy link
Member

ameukam commented May 7, 2021

Ran terraform apply -auto-approve -refresh
TF states are converted to 0.14.0

No changes as expected. .terraform.lock.hcl is created locally.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit a9615fb into kubernetes:main May 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sftim
Copy link

sftim commented Jun 15, 2021

Followed by #2217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants