Add initial terraform manifests for monitoring#1877
Add initial terraform manifests for monitoring#1877rikatz wants to merge 2 commits intokubernetes:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rikatz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| */ | ||
|
|
||
| terraform { | ||
| required_version = "~> 0.14.0" |
| // Manual step: Create a StackDriver alert channel pointing to a channel in Slack | ||
| // It will select the channel here by its display name | ||
| data "google_monitoring_notification_channel" "alertchannel" { | ||
| display_name = "Kubernetes.io Cert Alert" |
There was a problem hiding this comment.
We can use the existing channel : #k8s-infra-alerts. Can you mention the type ?
|
@ameukam thanks! I've changed the channel searcher to use the channel name (label) and the type slack, and did changed the terraform to >= 0.13.0 :) |
|
@ameukam anything else on this PR? I wanted to check if monitoring is working :) |
| terraform { | ||
|
|
||
| backend "gcs" { | ||
| bucket = "k8s-infra-clusters-terraform" |
| required_providers { | ||
| google = { | ||
| source = "hashicorp/google" | ||
| version = "~> 3.63.0" |
There was a problem hiding this comment.
| version = "~> 3.63.0" | |
| version = "~> 3.66.0" |
| */ | ||
|
|
||
| terraform { | ||
| required_version = ">= 0.13.0" |
There was a problem hiding this comment.
| required_version = ">= 0.13.0" | |
| required_version = ">= 0.14.0" |
See: #2019
Sorry for make you revert it. :-D
There was a problem hiding this comment.
This will need a rebase / update I think now, should be:
| required_version = ">= 0.13.0" | |
| required_version = "~> 1.0.0" |
|
@rikatz I dropped some comments. |
|
I have a meta-level nit which is that right now I think @ameukam has preferred to keep all of our terraform stuff in infra/gcp/clusters I feel like we need to chat a bit about what we want organization of files to look like, but until then I think having them all homed under one directory (even if its name is misleading) makes more sense than allowing sprawl So move to something like |
|
I'm ok with merge and iterate if we immediately follow up with that move |
|
Let's do this :) |
|
@rikatz: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add initial manifest for gitops monitoring.
Some points of attention for this PR: