Skip to content

Enable GCR for e2e projects#1536

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
spiffxp:enable-gcr-for-e2e-projects
Jan 15, 2021
Merged

Enable GCR for e2e projects#1536
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
spiffxp:enable-gcr-for-e2e-projects

Conversation

@spiffxp
Copy link
Copy Markdown
Contributor

@spiffxp spiffxp commented Jan 15, 2021

This is needed specifically by the scale projects to be able to run kubemark, but I would like the "push to GCR repo in the project boskos gave to my job, with no expectation the image will live beyond the job" pattern to be possible for all e2e projects.

ref: #1535

This is needed specifically by the scale projects to be able to run
kubemark, but I would like the "push to GCR repo in the project boskos
gave to my job, with no expectation the image will live beyond the job"
pattern to be possible for all e2e projects.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 15, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from dims and nikhita January 15, 2021 02:48
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2021
@spiffxp
Copy link
Copy Markdown
Contributor Author

spiffxp commented Jan 15, 2021

/cc @BenTheElder
any concerns with this?

@ameukam
Copy link
Copy Markdown
Member

ameukam commented Jan 15, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6c7805c into kubernetes:master Jan 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 15, 2021
@spiffxp
Copy link
Copy Markdown
Contributor Author

spiffxp commented Jan 15, 2021

Running ./infra/gcp/ensure-e2e-projects.sh

@spiffxp spiffxp deleted the enable-gcr-for-e2e-projects branch January 15, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants