Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology Manager KEP (Moving to new repo) #781

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

lmdaly
Copy link
Contributor

@lmdaly lmdaly commented Jan 30, 2019

KEP merged to community repo: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/node/topology-manager.md
Moving to enhancements repo as per 1.14 release requirements for each feature to have a KEP in this repo.

Topology Manager component in Kubelet which collects hints from other Kubelet components in order to create a best fit Socket alignment.

@k8s-ci-robot k8s-ci-robot added do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 30, 2019
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/pm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2019
@lmdaly
Copy link
Contributor Author

lmdaly commented Jan 30, 2019

@lmdaly lmdaly mentioned this pull request Jan 30, 2019
11 tasks
* Alpha-level documentation.
* Unit test coverage.
* Node e2e tests.
* CPU Manager allocation policy takes topology hints into account.
Copy link

@resouer resouer Feb 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make a concrete example of GPU topology? It seems topology manager is not supposed to be CPU (NUMA) only according to the context.

Copy link
Member

@derekwaynecarr derekwaynecarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the use of kep number, and we can merge this as there are no major changes from kubernetes/community#1680

keps/NEXT_KEP_NUMBER Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Mar 4, 2019
@derekwaynecarr
Copy link
Member

thanks for the update.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, lmdaly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 098315d into kubernetes:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants