-
Notifications
You must be signed in to change notification settings - Fork 1.7k
KEP-5607: Add implementation content for v1.36 #5745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the issue of mount options, there is currently some controversy as we have not yet clarified whether we should adopt
rroor continue usingrofor now. Therefore, I have documented the CRI implementation here in the hope of fostering more discussion.Some context for the discussion: containerd/containerd#12518 (comment)
/cc @AkihiroSuda @rata @haircommander @giuseppe @mikebrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was talking with some kernel devs and using rro is safe and the recommended way from their POV.
Ideally we would want a bind, not rbind, mount of sysfs. But that is not really possible because it has mount-points inside, the kernel doesn't allow it. Then, what we need to do is use rbind and rro and in this way we make sure the container can't change anything there.
This is safe as is, but even more if we take into account that using the host network namespace is a privileged PSS in Kubernetes.
LGTM. Thanks!