Skip to content

KEP-5607: Add implementation content for v1.36#5745

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
HirazawaUi:kep-5607-v1.36
Feb 10, 2026
Merged

KEP-5607: Add implementation content for v1.36#5745
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
HirazawaUi:kep-5607-v1.36

Conversation

@HirazawaUi
Copy link
Contributor

@HirazawaUi HirazawaUi commented Dec 18, 2025

  • One-line PR description: Add a UserNamespacesHostNetwork Runtime Handler for the UserNamespacesHostNetwork feature gate, and integrate node feature declaration feature.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Dec 18, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2025
@haircommander
Copy link
Contributor

I think I could use a bit of clarity on https://github.com/kubernetes/kubernetes/pull/135828/changes#r2733484515: if the node has some runtime handlers that use this, but some that don't, then is it possible to have the scheduler deny, or is potentially getting stuck in ContainerCreating in that case unavoidable?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2026
@HirazawaUi HirazawaUi force-pushed the kep-5607-v1.36 branch 3 times, most recently from 22b094a to 4f0891c Compare February 4, 2026 16:07
- `nodev`: Prevents unauthorized access to hardware through device files.
- `noexec`: Prevents execution of binary programs from the mounted filesystem.
- `rbind`: Ensures that the directory is mounted along with all its sub-mount points.
- `rro`: Ensures that the entire directory tree, including sub-mount points, is mounted as read-only.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the issue of mount options, there is currently some controversy as we have not yet clarified whether we should adopt rro or continue using ro for now. Therefore, I have documented the CRI implementation here in the hope of fostering more discussion.

Some context for the discussion: containerd/containerd#12518 (comment)

/cc @AkihiroSuda @rata @haircommander @giuseppe @mikebrow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was talking with some kernel devs and using rro is safe and the recommended way from their POV.

Ideally we would want a bind, not rbind, mount of sysfs. But that is not really possible because it has mount-points inside, the kernel doesn't allow it. Then, what we need to do is use rbind and rro and in this way we make sure the container can't change anything there.

This is safe as is, but even more if we take into account that using the host network namespace is a privileged PSS in Kubernetes.

LGTM. Thanks!

@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2026
@k8s-ci-robot k8s-ci-robot merged commit 84ec8f3 into kubernetes:master Feb 10, 2026
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants