KEP-3751: Update for milestone 1.31

[AndrewSirenko]

• One-line PR description: Update milestone 1.31 and fill out PRR

• Issue link: Kubernetes VolumeAttributesClass ModifyVolume #3751

• Other comments: Few items to be updated by enhancement freeze.

[k8s-ci-robot]

Welcome @AndrewSirenko!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @AndrewSirenko. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[xing-yang]

/ok-to-test

[xing-yang]

Please update this PRR yaml file for beta: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-storage/3751.yaml

/assign @johnbelamaric
for PRR review

[xing-yang]

/assign @msau42

[carlory]

Do we need two beta stages to solve the beta API not available by default? If so, we may need to mention it in the KEP.

cc @msau42

[AndrewSirenko]

If we will have 2 beta stages, I will change wording to the following.

- Beta in 1.31 –  Feature gate on API Server enabled by default (Off by default in external-provisioner/external-resizer): Since this feature is an extension of the external-resizer/external-provisioner usage flow, we are going to move this to beta with enhanced e2e and test coverage. Test cases are covered in sessions above: ``e2e tests``, ``Integration tests`` etc. 
- Beta stage 2 in 1.3x – Feature gate enabled API Server **and** external-provisioner/external-resizer by default. 

[msau42]

It's referring to this https://github.com/kubernetes/enhancements/tree/master/keps/sig-architecture/3136-beta-apis-off-by-default

So the feature gates are on by default, but the API is off. This implies that the controllers need to handle this.

[AndrewSirenko]

Changing wording back. I assume the following is fine:

- Beta in 1.31: Since this feature is an extension of the external-resizer/external-provisioner usage flow, we are going to move this to beta with enhanced e2e and test coverage. Test cases are covered in sessions above: ``e2e tests``, ``Integration tests`` etc. Controllers will handle VolumeAttributeClass feature gates being on by default, but beta API itself being disabled on clusters by default.

[johnbelamaric]

/hold for SIG approval
/approve for PRR

[johnbelamaric]

Once there is SIG approval you can unhold (my approval doesn't count for the SIG, but the tooling looks that way).

[msau42]

/lgtm
/approve

/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko, johnbelamaric, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• keps/prod-readiness/OWNERS [johnbelamaric]
• keps/sig-storage/OWNERS [johnbelamaric,msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment