Kubernetes VolumeAttributesClass ModifyVolume

[sunnylovestiramisu]

Enhancement Description

• One-line enhancement description (can be used as a release note): An extension to the Kubernetes Persistent Volume API to allow users to dynamically control volume options iops + throughput.

• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/3751-volume-attributes-class/README.md

• Discussion Link:

• CSI Spec for ModifyVolume
• keps/sig-storage/3751-volume-attributes-class
• KEP-3751: Fix the definition of the VolumeAttributesClass #4116

• Primary contact (assignee): @mattcary @sunnylovestiramisu
• Responsible SIGs: sig-storage
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.29
  • Beta release target (x.y): 1.31
  • Stable release target (x.y): 1.3x
• Alpha
  • KEP (k/enhancements) update PR(s):
    • KEP-3751: Kubernetes VolumeAttributesClass ModifyVolume #3780
    • Update Graduation Criteria for kep-3751 #4245
    • Update ControllerModifyVolume Status API #4298
  • Code (k/k) update PR(s):
    • v1.29: [KEP-3751] introduce the VolumeAttributesClass API kubernetes#121104
    • Pass VolumeAttributesClass Parameters as MutableParameters to CreateVolume kubernetes-csi/external-provisioner#1068
  • Docs (k/website) update PR(s):
    • v1.29: Add docs about VolumeAttributesClass API (KEP-3751) website#43463
    • 1.29 - Add a blog post about VolumeAttributesClass website#43777

• Beta
  • KEP (k/enhancements) update PR(s): KEP-3751: Update for milestone 1.31 #4698
  • Code (k/k) update PR(s):
    • vac add e2e test kubernetes#121849
    • [kep-3751] pvc bind pv with vac kubernetes#121902
    • Add labels to PVCollector bound/unbound PVC metrics for VolumeAttributesClass Feature#126166
    • [KEP-3751] Promote VolumeAttributesClass to beta #126145
    • Not required for 1.31 code freeze: A new controller adds/removes finalizer to VAC for protection kubernetes#123549
  • Docs (k/website) update(s): KEP-3751 VolumeAttributeClass Beta Promotion website#46785
  • Blog: Add post-release blog article for VAC beta website#46900

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[sunnylovestiramisu]

/sig storage

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[sunnylovestiramisu]

/remove-lifecycle stale

[salehsedghpour]

Hello @sunnylovestiramisu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.28
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• Update status to implementable in kep.yaml
• Add the test plan in the readme file
• Address questions inside the Production Readiness Review Questionnaire

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[salehsedghpour]

Hi @sunnylovestiramisu 👋, just checking in before the enhancements freeze on 01:00 UTC Friday, 16th June 2023.

The status for this enhancement is at risk.

For this KEP, we would just need to update the following:

• Update status to implementable in kep.yaml
• Add the test plan in the readme file
• Address questions inside the Production Readiness Review Questionnaire

Let me know if I missed anything. Thanks!

[AdminTurnedDevOps]

Hey @sunnylovestiramisu

1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[sunnylovestiramisu]

@AdminTurnedDevOps I think we just need a placeholder PR so that the docs team can add it to tracking. I will follow the instructions, thanks!

[carlory]

Hi @sunnylovestiramisu , Could you update the link of Kubernetes Enhancement Proposal to https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3751-volume-attributes-class.

The pr link is difficult for users to learn the content of this KEP.

[salehsedghpour]

Hey again @sunnylovestiramisu 👋
Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

[sunnylovestiramisu]

@salehsedghpour So far there was only one PR in review and I discussed with sig-storage lead @msau42 from now on we want to make sure the release in k8s and csi side cars all be ready before merging any PRs.

We will move alpha completion to 1.29.

[salehsedghpour]

@sunnylovestiramisu, to ensure we are on the same page, is there any plan to move ahead with the KEP in this release, or is it intended to be deferred to the next release which will result in marking it as Deferred to the next release?

[mattcary]

#4676 is in the middle of discussion.

[dipesh-rawat]

Hello @sunnylovestiramisu @AndrewSirenko 👋, 1.31 Enhancements team here,

Now that PR #4698 has been merged, all the KEP requirements are in place and merged into k/enhancements.

Before the enhancement freeze, it would be appreciated if following nits could be addressed:

• Update issue description to add direct link to KEP README.md

  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/3751-volume-attributes-class/README.md

• Update issue description to do the following:

  • Add section for 'Beta' stage and mention KEP (k/enhancements) update PR(s): KEP-3751: Update for milestone 1.31 #4698

• Ensure that this issue has an assignee.

Aside from the minor nits mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[mattcary]

Thanks for fixing those nits, @xing-yang !

I'm a good assignee while @sunnylovestiramisu is on leave.

[edithturn]

Hello, @mattcary and @sunnylovestiramisu!

👋 from the v1.31 Communications Team!

We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[mattcary]

kubernetes/website#46785 already started

/cc @AndrewSirenko

[xing-yang]

@mattcary I think kubernetes/website#46785 is the doc change placeholder PR.
For the blog, another placeholder PR needs to be submitted against the "main" branch.

[mattcary]

Oops! you're right. So many placeholders....

I'll start the blog one.

[mattcary]

kubernetes/website#46900 created.

[edithturn]

kubernetes/website#46900 created.

Hello @mattcary, thank you for your response! Please let me know if you need any help!

[dipesh-rawat]

Hey again @sunnylovestiramisu! @mattcary @carlory 👋, 1.31 Enhancements team here,

Just checking in as we approach code freeze at at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

(Compiled the following list based on the mention of KEP 3751 in the description. Please let me know if there are any PRs listed below that don't require tracking as part of this KEP)

• vac add e2e test kubernetes#121849
• [kep-3751] pvc bind pv with vac kubernetes#121902
• [KEP-3751] Promote VolumeAttributesClass to beta kubernetes#126145
• Add labels to PVCollector bound/unbound PVC metrics for VolumeAttributesClass Feature kubernetes#126166
• (Optional for v1.31 release) A new controller adds/removes finalizer to VAC for protection kubernetes#123549

Additionally, please let me know if there are any other PRs in k/k not listed above that we should track for this KEP, so that we can maintain accurate status.

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

[dipesh-rawat]

Hey again @sunnylovestiramisu! @mattcary @carlory 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in around two weeks time, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. There are a few requirements mentioned in the comment #3751 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance.

[AndrewSirenko]

Docs modification PR Ready for review: KEP-3751 VolumeAttributeClass Beta Promotion

CC @MaryamTavakkoli, thank you!

[dipesh-rawat]

Hey again @sunnylovestiramisu! @mattcary @carlory 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze next week, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. There are a few requirements mentioned in the comment #3751 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance.

[dipesh-rawat]

Hey again @sunnylovestiramisu! @mattcary @carlory 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in less than 2 days, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. There are a few requirements mentioned in the comment #3751 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance.

[AndrewSirenko]

Hi @dipesh-rawat, the following PRs should no longer be tracked for Kubernetes v1.31.

• Add quota support for PVC with VolumeAttributesClass kubernetes#124360
• Add quota support for PVC with VolumeAttributesClass kubernetes#121895

See #4765 for more information!

Also:

• A new controller adds/removes finalizer

Is optional for Kubernetes v1.31. If it gets approved in time, that is great, but it should NOT block enhancement promotion to beta!

We will update issue with correct PRs now. Thank you so much for your help/updates!

[dipesh-rawat]

@AndrewSirenko Thank you for confirming the list of PRs to track for this KEP. I’ve updated the original comment accordingly. I’ll update the status of the KEP on the v1.31 project board closer to the code freeze deadline time later today. Thanks for keeping us informed and ensuring everything is up to date.

[AndrewSirenko]

@dipesh-rawat looks like the final blocking PR is approved by all relevant stakeholders: kubernetes/kubernetes#126145 (comment)

Should merge soon.

Thanks again!

[dipesh-rawat]

Hey again @AndrewSirenko @mattcary @carlory 👋, 1.31 Enhancements team here,

Everything seems to be in place for this KEP issue now that the following code implementation PRs have been merged.

• vac add e2e test kubernetes#121849
• [kep-3751] pvc bind pv with vac kubernetes#121902
• [KEP-3751] Promote VolumeAttributesClass to beta kubernetes#126145
• Add labels to PVCollector bound/unbound PVC metrics for VolumeAttributesClass Feature kubernetes#126166

This enhancement is now marked as tracked for code freeze for the 1.31 Code Freeze!

[tjons]

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in