Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1933: Update references to deprecated KEP-1753. #3114

Merged
merged 1 commit into from
Apr 13, 2022
Merged

KEP-1933: Update references to deprecated KEP-1753. #3114

merged 1 commit into from
Apr 13, 2022

Conversation

PurelyApplied
Copy link
Contributor

@PurelyApplied PurelyApplied commented Jan 6, 2022 •
edited
Loading

  • One-line PR description: Update KEP-1933 references to now-deprecated KEP-1753

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/security Categorizes an issue or PR as relevant to SIG Security. labels Jan 6, 2022
@PurelyApplied PurelyApplied force-pushed the update-1933-for-deprecated-1753 branch from 02121ce to 39fd74a Compare January 7, 2022 21:44
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2022
@PurelyApplied PurelyApplied marked this pull request as ready for review January 7, 2022 22:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2022
ehashman
ehashman reviewed Mar 3, 2022
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2022
@ehashman ehashman mentioned this pull request Mar 3, 2022
Merged
@ehashman
Copy link
Member

ehashman commented Mar 3, 2022

/assign @tabbysable

@tabbysable
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PurelyApplied, tabbysable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit d2ac6fe into kubernetes:master Apr 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@IanColdwater IanColdwater Awaiting requested review from IanColdwater

@tabbysable tabbysable Awaiting requested review from tabbysable

Assignees

@ehashman ehashman

@tabbysable tabbysable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/security Categorizes an issue or PR as relevant to SIG Security. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@PurelyApplied @k8s-ci-robot @ehashman @tabbysable