-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-1753: Deprecate dynamic log sanitization #3096
KEP-1753: Deprecate dynamic log sanitization #3096
Conversation
ehashman
commented
Dec 23, 2021
- One-line PR description: Deprecate dynamic log sanitization
- Issue link: Kubernetes system components logs sanitization #1753
- Other comments: See kubernetes-dev post https://groups.google.com/g/kubernetes-dev/c/xhQuwdd2Smw
SIG Instrumentation is leading the deprecation of this feature as we own some of the code. We started it, we'll finish it :)
/hold awaiting sufficient feedback, preventing accidental merges |
/lgtm Not removing the hold just now |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, tabbysable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label tide/merge-method-squash |
This KEP overlapped with KEP-1933's static analysis a bit, notably that the analysis is intended to be based on the struct tags proposed as part of this KEP. In the last SIG-Security meeting, we discussed splitting the stuct-tags portion into its own KEP in the near future. I don't know that there's anything actionable on that info (other than writing the new KEP), just FYI. (Also mentioned in the PR.) |
@PurelyApplied It's a good idea to update KEP 1933 to import responsibility for the struct tags. Feel free to just do it yourself, or come to SIG Security (slack or meeting) and ask for assistance. |
@PurelyApplied Since the static analysis needs the data policy tags I have left them in. Let me update the KEP to state this expectation explicitly as part of the deprecation plan. |
9d8a3a2
to
1ab8725
Compare
/hold cancel |
/lgtm |
* Rehome KEP-1753 for deprecation SIG Instrumentation is leading the deprecation of this feature as we own some of the code. We started it, we'll finish it :) * Update KEP-1753 metadata for deprecation * Update KEP-1753 with deprecation notice