Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generic types from 'ResourceBase' to resolve failed test cases #6986

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Remove generic types from 'ResourceBase' to resolve failed test cases #6986

merged 2 commits into from
Apr 7, 2022

Conversation

xiaoyang-sde
Copy link
Contributor

@xiaoyang-sde xiaoyang-sde commented Apr 7, 2022

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #6986 (0ddf614) into master (dd9dc92) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #6986   +/-   ##
=======================================
  Coverage   41.78%   41.78%           
=======================================
  Files          45       45           
  Lines        1230     1230           
  Branches      177      177           
=======================================
  Hits          514      514           
  Misses        678      678           
  Partials       38       38           

@maciaszczykm
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, xiaoyang-sde

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 92da43d into kubernetes:master Apr 7, 2022
@xiaoyang-sde xiaoyang-sde deleted the hotfix branch April 7, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants